Skip to content
This repository was archived by the owner on Jan 9, 2025. It is now read-only.

refactor: account model #1043

Merged
merged 13 commits into from
Mar 28, 2024
Merged

refactor: account model #1043

merged 13 commits into from
Mar 28, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Mar 25, 2024 •
edited
Loading

Time spent on this PR: 2.5d

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #1023

What is the new behavior?

  • Remove EOA / CA distinction => Merged in generic_account
  • Remove proxy pattern and use replace_class.
  • Ensure deterministic address calculation using an uninitialized_account class whose sole purpose is to be upgraded to the latest account version

This change is Reviewable

@enitrat enitrat force-pushed the refactor/account-model branch from db60658 to 8af9286 Compare March 26, 2024 17:45
@enitrat enitrat force-pushed the refactor/account-model branch 2 times, most recently from 9d5b2b1 to 26ef598 Compare March 27, 2024 19:30
@enitrat enitrat changed the title refactor(wip): account model refactor: account model Mar 28, 2024
@enitrat enitrat force-pushed the refactor/account-model branch from 426e602 to 48664a9 Compare March 28, 2024 14:39
@enitrat enitrat marked this pull request as ready for review March 28, 2024 14:39
@enitrat enitrat force-pushed the refactor/account-model branch from 48664a9 to 46415cb Compare March 28, 2024 14:39
@enitrat enitrat force-pushed the refactor/account-model branch from 46415cb to ddb0230 Compare March 28, 2024 14:39
@enitrat enitrat merged commit 21a51d4 into main Mar 28, 2024
7 checks passed
@enitrat enitrat deleted the refactor/account-model branch March 28, 2024 19:23
This was referenced Apr 4, 2024
Merged
Merged
@ClementWalter ClementWalter mentioned this pull request Apr 12, 2024
Merged
@ClementWalter ClementWalter mentioned this pull request May 30, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ClementWalter ClementWalter ClementWalter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

epic: refactor account model in kakarot
2 participants
@enitrat @ClementWalter