Skip to content
This repository was archived by the owner on Jan 9, 2025. It is now read-only.

Optimize get_jumpdests #1034

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Optimize get_jumpdests #1034

merged 3 commits into from
Mar 27, 2024

Conversation

feltroidprime
Copy link
Contributor

@feltroidprime feltroidprime commented Mar 13, 2024

  • add is_le_unchecked function
  • exit the loop without using is_le at each iteration. Only done once at exit.

Before :
image

After :
image


This change is Reviewable

@feltroidprime
Copy link
Contributor Author

feltroidprime commented Mar 13, 2024

@ClementWalter just force pushed the required changes

Copy link
Member

@ClementWalter ClementWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a possible simplification

@ClementWalter
Copy link
Member

profile002
final profiling

@ClementWalter ClementWalter merged commit 1ea7414 into kkrt-labs:main Mar 27, 2024
6 checks passed
@ClementWalter ClementWalter mentioned this pull request Apr 12, 2024
matthieuauger pushed a commit to matthieuauger/kakarot that referenced this pull request Nov 9, 2024
* bump kakarot to 0.7.4

* fix docker

* revert build sol change

* fix docker

* fix hive docker

* fix docker

---------

Co-authored-by: Gregory Edison <gregory.edison1993@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants