Skip to content
This repository was archived by the owner on Jan 9, 2025. It is now read-only.

feat: charge transaction gas to the sender #1025

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Mar 11, 2024

Time spent on this PR: 0.5d

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves #

What is the new behavior?

  • Charges the sender for the gas consumed in the transaction and value sent.
  • Fixed state commitment to always commit the State on eth_send_transaction
  • For "reverted" txs, we reset the State before charging the gas.

This change is Reviewable

ClementWalter
ClementWalter previously approved these changes Mar 11, 2024
ClementWalter
ClementWalter previously approved these changes Mar 12, 2024
@enitrat enitrat force-pushed the feat/charge-transaction-gas branch from 85147c4 to 43c4efb Compare March 12, 2024 11:25
@enitrat enitrat merged commit 46b0fff into main Mar 12, 2024
7 checks passed
@enitrat enitrat deleted the feat/charge-transaction-gas branch March 12, 2024 12:22
matthieuauger pushed a commit to matthieuauger/kakarot that referenced this pull request Nov 9, 2024
* Add proptest for split_u256

* fix comment

* clean up

* Empty-Commit
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants