Add optional timeout argument to probe

[magnusvmt]

Popen.communicate() supports a timeout argument which is useful in case
there is a risk that the probe hangs indefinitely.

[spirulence]

@magnusvmt couple of questions from an interested bystander -

• I don't think python 2.7 has the equivalent parameter, so this appears to break Python 2 and PyPy compatibility, see the failing check. What's the best way to resolve that?
• ffprobe also takes a timeout parameter, does adding an argument for it here prevent it from being passed down?

[153957]

What's the best way to resolve that?

Wait 2 months, then Python 2.7 will no longer be supported.

[kkroening]

Maybe something like this:

communicate_kwargs = {}
if timeout is not None:
    communicate_kwargs['timeout'] = timeout
out, err = p.communicate(**communicate_kwargs)

Of course, if someone specifies timeout on Python 2, they'll get an error, but that's probably not worth worrying about so long as the tests pass.

Relatedly, there should be a test for use of this newly-added timeout param, at least for Python >= 3

[magnusvmt]

@spirulence

• I don't think python 2.7 has the equivalent parameter, so this appears to break Python 2 and PyPy compatibility, see the failing check. What's the best way to resolve that?

Fixed with the code @kkroening provided, thanks!

• ffprobe also takes a timeout parameter, does adding an argument for it here prevent it from being passed down?

Does it really? I couldn't find anything about it here https://ffmpeg.org/ffprobe.html

[spirulence]

@magnusvmt it's not available on every source, but it's there for a few.

ffprobe -i https://svs.gsfc.nasa.gov/vis/a010000/a013400/a013425/13425.Mercury.transit2019V3_1YouTube4k.mp4 -timeout 10000

will actually time out as opposed to

ffprobe -i https://svs.gsfc.nasa.gov/vis/a010000/a013400/a013425/13425.Mercury.transit2019V3_1YouTube4k.mp4

[kkroening]

Merged. This will be included in the next release. Thanks!

[MarcoRizk]

Was this ever released to pypi ?