Use with pyinstaller frozen exe results in errors on Windows

[3ll3d00d]

Using this lib (for either ffprobe or ffmpeg) results in the following error when running on Windows

[WinError 6] The handle is invalid

Applying the suggested workaround from https://github.com/pyinstaller/pyinstaller/wiki/Recipe-subprocess to always set stdin resolves the issue for me

i.e.

in _run.py change https://github.com/kkroening/ffmpeg-python/blob/master/ffmpeg/_run.py#L205 to

stdin_stream = subprocess.PIPE

in _probe.py change https://github.com/kkroening/ffmpeg-python/blob/master/ffmpeg/_probe.py#L16 to

p = subprocess.Popen(args, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE)

I don't know if this covers all use cases or has any side effects, happy to PR the above though if you want me to.

[kkroening]

Interesting. I don't have a Windows machine to test this on, but good to know anyways. I'll leave this issue open for now for anyone to chime in, and hopefully get a chance to see if there's any downside to just unconditionally setting stdin_stream as you suggest.

Thanks for reporting. 👍