fix: resolve sharp dependency bundling issue in VSIX#2
Merged
Conversation
Sharp module was failing to load due to missing transitive dependency (detect-libc) in VSIX package. The .vscodeignore manual whitelist approach was error-prone and didn't include all required dependencies. Key changes: - Use bundleDependencies in package.json for automatic dependency inclusion - Add VSIX verification script to detect missing dependencies - Add CI step to verify VSIX before release - Improve Sharp load error logging for debugging - Clean up verbose logging (move debug info to debug level) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detect-libcdependencyChanges
Fixed
bundleDependenciesinstead of manual .vscodeignore whitelistgetSharpLoadError()for better debugging when Sharp fails to loadAdded
scripts/verify-vsix.mjs- Automated verification of VSIX dependenciesnpm run verify:vsixscriptChanged
Test Plan
🤖 Generated with Claude Code