Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 100mb download limit #301

Closed
wants to merge 1 commit into from
Closed

fix 100mb download limit #301

wants to merge 1 commit into from

Conversation

lidarbtc
Copy link

@lidarbtc lidarbtc commented Sep 2, 2023

Description

Remove getmaxRoutines(and just return parameter)

func (c *Client) getMaxRoutines(limit int) int {
	routines := 10

	if c.MaxRoutines > 0 {
		routines = c.MaxRoutines
	}

	if limit > 0 && routines > limit {
		routines = limit
	}

	return routines
}

This function simply limits MaxRoutines to 10.

Since each chunk is 10MB, the maximum download size is limited to 100MB.

So I removed the download size limit by deleting the function.

Issues to fix

Please link issues this PR will fix:
#298

Reminding

Something you can do before PR to reduce time to merge

  • run "make build" to build the code
  • run "make format" to reformat the code
  • run "make lint" if you are using unix system
  • run "make test-integration" to pass all tests

@corny
Copy link
Collaborator

corny commented Sep 4, 2023

We should still respect the MaxRoutines setting to don't have more routines. Please try my branch fix-298

@corny corny closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants