[nrfconnect] Added recovering CASE session for the light switch #65
+68
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There isn't CASE recovery mechanism, so after resetting lighting device, the light switch is not able to communicate with it, as it holds out of date CASE session. Added releasing CASE session in case invoke command failure due to timeout reason. After that new session is established and command retransmitted. CASE session is recovered only once per failure to prevent multiple tries in case comunnication is seriously broken.
kkasperczyk-no
requested review from
LuDuda,
Damian-Nordic,
ArekBalysNordic and
markaj-nordic
| private: | ||
| static void OnOffProcessCommand(chip::CommandId, const EmberBindingTableEntry &, chip::DeviceProxy *, void *); | ||
| static void LevelControlProcessCommand(chip::CommandId, const EmberBindingTableEntry &, chip::DeviceProxy *, void *); | ||
| static void LightSwitchChangedHandler(const EmberBindingTableEntry &, chip::DeviceProxy *, void *); | ||
| static void InitInternal(intptr_t); | ||
|
|
||
| bool mCaseSessionRecovered = false; |
There was a problem hiding this comment.
Move to BindingData? You won't need to clean this state on each transactions then.
There was a problem hiding this comment.
But binding data are related to the specific cluster and command, so it will not work if somebody send different commands one by one. I believe we should store this flag for a specific node ID, but for now we support only one node ID for unicast traffic, so I didn't care much about it.
There was a problem hiding this comment.
Ok, but now if there are two simultaneous commands sent and the CASE is lost, won't the second one be simply ignored? Anyway, probably it would require more work to make such scenarios work correctly, so nevermind.
Damian-Nordic
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't CASE recovery mechanism, so after resetting lighting
device, the light switch is not able to communicate with it,
as it holds out of date CASE session.
Added releasing CASE session in case invoke command failure due
to timeout reason. After that new session is established and command
retransmitted. CASE session is recovered only once per failure to
prevent multiple tries in case comunnication is seriously broken.