Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrfconnect] Refactored configuration for child images #64

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kkasperczyk-no
Copy link
Owner

Problem

Currently used approach for nrfconnect regarding child images results in significant duplication of configuration files,
what hardens maintenance.

Change overview

  • Created Kconfig.mcuboot.defaults file that sets default configuration for all examples using mcuboot child image
  • Created Kconfig.multiprotocol_rpmsg file that sets default configuration for all examples using multiprotocol
    rpmsg child image
  • Removed from rpc.overlay comment describing how to use it, as it duplicates example README.md information

Currently used approach for nrfconnect regarding child images
results in significant duplication of configuration files,
what hardens maintenance.

* Created Kconfig.mcuboot.defaults file that sets default
configuration for all examples using mcuboot child image
* Created Kconfig.multiprotocol_rpmsg file that sets
default configuration for all examples using multiprotocol
rpmsg child image
* Removed from rpc.overlay comment describing how to use it,
as it duplicates example README.md information
Copy link
Collaborator

@Damian-Nordic Damian-Nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the change mean that we're able to flatten the configuration tree and not to duplicate files across boards?

examples/lighting-app/nrfconnect/rpc.overlay Show resolved Hide resolved
@kkasperczyk-no
Copy link
Owner Author

Does the change mean that we're able to flatten the configuration tree and not to duplicate files across boards?

A little bit. We still need to duplicate prj.confs for mcuboot and multiprotocol_rpmsg in the child_image directories, as not all configs can be set in defaults, due to overrides in board files. At least we will get rid of plenty overlays containing the same options and having different names (like multiprotocol_rpmsg, multiprotocol_rpmsg_release, multiprotocol_rpmsg_no_dfu)

Copy link
Collaborator

@Damian-Nordic Damian-Nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please verify .config files (in both app/net/mcuboot images) for at least one example before and after your change :)

@kkasperczyk-no
Copy link
Owner Author

Please verify .config files (in both app/net/mcuboot images) for at least one example before and after your change :)

I tried to do so, but it's not so easy, as order of configs was changed because of using the defaults, so diff didn't help and I had to do this manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants