-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Refactored configuration for child images #64
base: master
Are you sure you want to change the base?
Conversation
476974f
to
794dcd3
Compare
Currently used approach for nrfconnect regarding child images results in significant duplication of configuration files, what hardens maintenance. * Created Kconfig.mcuboot.defaults file that sets default configuration for all examples using mcuboot child image * Created Kconfig.multiprotocol_rpmsg file that sets default configuration for all examples using multiprotocol rpmsg child image * Removed from rpc.overlay comment describing how to use it, as it duplicates example README.md information
794dcd3
to
1a95846
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the change mean that we're able to flatten the configuration tree and not to duplicate files across boards?
A little bit. We still need to duplicate prj.confs for mcuboot and multiprotocol_rpmsg in the child_image directories, as not all configs can be set in defaults, due to overrides in board files. At least we will get rid of plenty overlays containing the same options and having different names (like multiprotocol_rpmsg, multiprotocol_rpmsg_release, multiprotocol_rpmsg_no_dfu) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please verify .config files (in both app/net/mcuboot images) for at least one example before and after your change :)
examples/lighting-app/nrfconnect/boards/nrf52840dongle_nrf52840.conf
Outdated
Show resolved
Hide resolved
I tried to do so, but it's not so easy, as order of configs was changed because of using the defaults, so diff didn't help and I had to do this manually. |
a857c06
to
8763f1d
Compare
Problem
Currently used approach for nrfconnect regarding child images results in significant duplication of configuration files,
what hardens maintenance.
Change overview
rpmsg child image