[logging] Refactored logged messages #62
Open
+88
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Memory comparison for upstream lock-app on nRF52840dk with default configuration:
Summary: gained 26,02 kB |
kkasperczyk-no
force-pushed
the
logs_and_shell_optimization
branch
from
7aabe54
to
efbc31f
Compare
Many messages are logged in the scope that doesn't seem to be appropriate (errors as progress, very detail info as progress etc.) * Briefly reviewed ChipLog calls and changed scopes where it seemed to be valuable For nrfconnect: * Added setting gn chip logging flags depending on Kconfig CONFIG_MATTER_LOG_LEVEL option * Disabled not used shell modules * Changed Zephyr modules default log level from info to warning (all Zephyr modules are set to warning and only those that are important are set to info)
kkasperczyk-no
force-pushed
the
logs_and_shell_optimization
branch
from
efbc31f
to
99b8876
Compare
Damian-Nordic
approved these changes
Mar 22, 2022
markaj-nordic
approved these changes
Mar 22, 2022
LuDuda
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Many messages are logged in the scope that doesn't seem to be appropriate (errors as progress, very detail info as progress etc.)
Change overview
seemed to be valuable
For nrfconnect:
CONFIG_MATTER_LOG_LEVEL option
(all Zephyr modules are set to warning and only those that are
important are set to info)