[events] Added generating BootReason event #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkasperczyk-no
force-pushed
the
clusters_events
branch
4 times, most recently
from
befe233
to
a1d2f56
Compare
Zephyr platform doesn't support generating all mandatory events from Basic and General Diagnostics clusters. Generic changes: * Added generating BootReason event * Added Server::FactoryReset method to dispatch necessary events and flush pending events before factory reset * Added dispatching shutdown event on factory reset * Added DeleteAllFabrics in FactoryReset to emit Leave event. * Added flushing events on factory reset * Added for all examples to call Server FactoryReset instead of platform InitiateFactoryReset Zephyr platform changes: * Fixed bug in persisted storage read implementation that returned wrong error code and it resulted in PersistedCounter initialization failure. * Added calling Shutdown after factory reset WIP
kkasperczyk-no
force-pushed
the
clusters_events
branch
from
a1d2f56
to
5dc2eb6
Compare
src/include/platform/internal/GenericPlatformManagerImpl_Zephyr.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp
Outdated
Show resolved
Hide resolved
| @@ -204,9 +202,7 @@ void ConfigurationManagerImpl::DoFactoryReset(intptr_t arg) | |||
| ThreadStackMgr().ErasePersistentInfo(); | |||
| #endif // CHIP_DEVICE_CONFIG_ENABLE_THREAD | |||
|
|
|||
| #if CONFIG_REBOOT | |||
There was a problem hiding this comment.
nit: I guess this change isn't that necessary since we will probably need to support some custom reboot mechanism (to send the shutdown event in any case).
Damian-Nordic
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Zephyr platform doesn't support generating all mandatory events from Basic and General Diagnostics clusters.
Change overview
Generic changes:
necessary events and flush pending events before
factory reset
reset
Leave event.
instead of platform InitiateFactoryReset
Zephyr platform changes:
implementation that returned wrong error code
and it resulted in PersistedCounter initialization
failure.