Updated nodealign.js to address display issue#29
Open
Atom8403 wants to merge 2 commits intokk8bit:mainfrom
Open
Updated nodealign.js to address display issue#29Atom8403 wants to merge 2 commits intokk8bit:mainfrom
Atom8403 wants to merge 2 commits intokk8bit:mainfrom
Conversation
Fixed iconColor scope: moved variable declarations outside the try block so they're accessible throughout the function Enhanced CSS: added !important flags and default positioning for floating mode Forced visibility: set visibility: visible, opacity: 1, and z-index: 10000 directly on the element Added minimum dimensions: minWidth: 200px and minHeight: 32px to prevent zero-size toolbar Added diagnostic logging: logs computed styles, position, and dimensions when show() is called Improved positioning: handles zero-dimension case and uses a default centered position
Author
|
I updated the nodealign.js to resolve the issue of it not displaying after the latest ComfyUI update |
The toolbar should now: Hide when no nodes are selected in "on-select" mode Show only when 2+ nodes are selected Stay properly positioned on-screen (not cut off) *This was happening when i was working on hiding and showing the bar Respect the display mode setting The fix was using setProperty() with the important flag and adding a CSS class with higher specificity to override the base display: flex !important; rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed iconColor scope: moved variable declarations outside the try block so they're accessible throughout the function
Enhanced CSS: added !important flags and default positioning for floating mode
Forced visibility: set visibility: visible, opacity: 1, and z-index: 10000 directly on the element
Added minimum dimensions: minWidth: 200px and minHeight: 32px to prevent zero-size toolbar
Added diagnostic logging: logs computed styles, position, and dimensions when show() is called
Improved positioning: handles zero-dimension case and uses a default centered position