Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yaml_tag instead of yaml_as, which was deprecated in Ruby 2.4 and removed in 2.5 #298

Merged
merged 1 commit into from
Jan 13, 2018

Conversation

mattbrictson
Copy link

Replace yaml_as with yaml_tag as directed by the deprecation warning. This allows sitemap_generator to work with Ruby 2.5.0. πŸŽ‰

I also ran the specs using Ruby 2.5.0 just to be sure – everything passes.

Fixes #297.

Replace with yaml_tag as directed by the deprecation warning.
@avokhmin
Copy link

avokhmin commented Jan 2, 2018

@kjvarga , something wrong here?

@kjvarga
Copy link
Owner

kjvarga commented Jan 2, 2018

I'll get this resolved in the next couple days

@natdjerf
Copy link

@kjvarga , anything you need to help get this resolved?

@kjvarga kjvarga merged commit 175ea4b into kjvarga:master Jan 13, 2018
@mattbrictson mattbrictson deleted the replace-yaml_as-with-yaml_tag branch January 13, 2018 01:10
@kjvarga
Copy link
Owner

kjvarga commented Jan 13, 2018

Thanks for the pull request and offer of support. Released in v6.0.1 https://rubygems.org/gems/sitemap_generator/versions/6.0.1

@kjvarga
Copy link
Owner

kjvarga commented Jan 13, 2018

You're a cutting-edge bunch! What's odd is that when I install rbenv install 2.5.0-dev the ruby version is reported as:

kvarga at KarlWork in ~/Projects/sitemap_generator on master*
$ rbenv shell 2.5.0-dev
kvarga at KarlWork in ~/Projects/sitemap_generator on master*
$ ruby --version
ruby 2.6.0dev (2018-01-13 trunk 61799) [x86_64-darwin17]

Why is that 2.6.0??

@mattbrictson
Copy link
Author

I think until recently 2.5.0-dev was an alias for the Ruby master branch. So you're probably getting the latest master ruby, which now is 2.6.0dev. Updating ruby-build will probably fix that discrepancy.

Ruby 2.5.0 was officially released on 2017-12-25 so after updating ruby-build you can run rbenv install 2.5.0 to get it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants