Repository navigation
Link FreeBSD builds against the FreeBSD 12 libc again - #154
Merged
Merged
Conversation
std's `available_parallelism` calls `sched_getaffinity` on FreeBSD, which FreeBSD 12 libc lacks, so both FreeBSD release legs failed to link. On FreeBSD the extractor pool now sizes itself with `num_cpus::get()`, which uses `sysconf` and `sysctl`. Other targets keep `available_parallelism`.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
runner | d88cf02 | Commit Preview URL Branch Preview URL |
Sep 27 2026, 11:05 PM |
kjanat
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both FreeBSD legs of the v0.27.0 release failed to link with
undefined reference to sched_getaffinity. std'savailable_parallelismcalls it on FreeBSD, and it only exists from FreeBSD 13.1.On FreeBSD the extractor pool now uses
num_cpus::get(), which readssysconf(_SC_NPROCESSORS_ONLN)with asysctl hw.ncpufallback. Every other target keepsavailable_parallelism.Both
x86_64-unknown-freebsdandaarch64-unknown-freebsd(nightly-Z build-std) link against the FreeBSD 12.4 sysroots CI uses, and each binary importssysconf@FBSD_1.0and nosched_getaffinity.