Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kiwix desktop zip #775

Merged
merged 2 commits into from
Nov 2, 2024
Merged

Fix kiwix desktop zip #775

merged 2 commits into from
Nov 2, 2024

Conversation

kelson42
Copy link
Contributor

Fixes #754

@kelson42 kelson42 requested a review from rgaudin October 31, 2024 15:44
@rgaudin
Copy link
Member

rgaudin commented Nov 1, 2024

@kelson42 have you tested this?

@kelson42
Copy link
Contributor Author

kelson42 commented Nov 2, 2024 •
edited
Loading

@rgaudin I have run the python script by hand and seems to work (output ZIP was OK)

rgaudin
rgaudin approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK LGTM (haven't tested though)

@kelson42 kelson42 merged commit 6cb347c into main Nov 2, 2024
40 checks passed
@kelson42 kelson42 deleted the fix-kiwix-desktop-zip branch November 2, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kiwix-desktop inside a folder
2 participants
@kelson42 @rgaudin