Skip to content

Search feature does too much of magic #983

Open

Description

Current search is a mix of a fulltext search and suggestions. To allow proper merging of results, the swift code does a bit of magic and heuristics.

This leads to:

  • Complexity in the code
  • Slower computations
  • Discrepencies with other readers

This is not how it should work.

The Kiwix reader should reuse straight the results provided by the libzim.

Here are two proposals to change the behaviour to be more conform:

  • Make a suggestion search per default (like in Kiwix Desktop of Kiwix Android) ie. while user is typing propose titles matching the search pattern. Provide an optional fulltext search if user can/wants (with result snippets)
  • Make a suggestion search per default (like in Kiwix Desktop of Kiwix Android) ie. while user is typing propose titles matching the search pattern... and last item of the suggestion list allow to trigger a fulltext search (this is how works Kiwix Desktop)

FYI, Kiwix Android does not provide yet fulltext search feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions