Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Resolved the issue where Google Play Store displayed an error during APK upload. #3641

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Dec 28, 2023

Fixes #3640

  • We have excluded the universal APK from the variant list that is being uploaded to the Play Store.
  • This exclusion is necessary because we cannot disable the universal APK, as it is required to set the version code for the bundle. Disabling the universal APK would result in the bundle version code being set exclusively for x86_64.

After placing this fix the variant list not contains the universal apk

[ApkVariantOutputImpl_Decorated{variantOutput=VariantOutputImpl(versionCode=property(java.lang.Integer, fixed(class java.lang.Integer, 3233620)), versionName=property(java.lang.String, fixed(class java.lang.String, 2023-12)), enabled=property(java.lang.Boolean, fixed(class java.lang.Boolean, true)), variantOutputConfiguration=VariantOutputConfigurationImpl(isUniversal=false, filters=[FilterConfiguration(filterType=ABI, identifier=x86)]), baseName=customexample-x86-release, fullName=customexampleX86Release, outputFileName=property(java.lang.String, fixed(class java.lang.String, custom-customexample-x86-release.apk)))}, ApkVariantOutputImpl_Decorated{variantOutput=VariantOutputImpl(versionCode=property(java.lang.Integer, fixed(class java.lang.Integer, 4233620)), versionName=property(java.lang.String, fixed(class java.lang.String, 2023-12)), enabled=property(java.lang.Boolean, fixed(class java.lang.Boolean, true)), variantOutputConfiguration=VariantOutputConfigurationImpl(isUniversal=false, filters=[FilterConfiguration(filterType=ABI, identifier=x86_64)]), baseName=customexample-x86_64-release, fullName=customexampleX86_64Release, outputFileName=property(java.lang.String, fixed(class java.lang.String, custom-customexample-x86_64-release.apk)))}, ApkVariantOutputImpl_Decorated{variantOutput=VariantOutputImpl(versionCode=property(java.lang.Integer, fixed(class java.lang.Integer, 5233620)), versionName=property(java.lang.String, fixed(class java.lang.String, 2023-12)), enabled=property(java.lang.Boolean, fixed(class java.lang.Boolean, true)), variantOutputConfiguration=VariantOutputConfigurationImpl(isUniversal=false, filters=[FilterConfiguration(filterType=ABI, identifier=armeabi-v7a)]), baseName=customexample-armeabi-v7a-release, fullName=customexampleArmeabi-v7aRelease, outputFileName=property(java.lang.String, fixed(class java.lang.String, custom-customexample-armeabi-v7a-release.apk)))}, ApkVariantOutputImpl_Decorated{variantOutput=VariantOutputImpl(versionCode=property(java.lang.Integer, fixed(class java.lang.Integer, 6233620)), versionName=property(java.lang.String, fixed(class java.lang.String, 2023-12)), enabled=property(java.lang.Boolean, fixed(class java.lang.Boolean, true)), variantOutputConfiguration=VariantOutputConfigurationImpl(isUniversal=false, filters=[FilterConfiguration(filterType=ABI, identifier=arm64-v8a)]), baseName=customexample-arm64-v8a-release, fullName=customexampleArm64-v8aRelease, outputFileName=property(java.lang.String, fixed(class java.lang.String, custom-customexample-arm64-v8a-release.apk)))}]

If we disabled the universal apk then the bundle set like it is x86_64 bundle
Screenshot from 2023-12-28 19-18-08

So we have not disabled the universal apk

Screenshot from 2023-12-28 19-15-59

…during APK upload.

* We have excluded the universal APK from the variant list that is being uploaded to the Play Store.
* This exclusion is necessary because we cannot disable the universal APK, as it is required to set the version code for the bundle. Disabling the universal APK would result in the bundle version code being set exclusively for `x86_64`.
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f41701c) 48.93% compared to head (62883fe) 48.68%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3641      +/-   ##
============================================
- Coverage     48.93%   48.68%   -0.25%     
  Complexity     1090     1090              
============================================
  Files           285      285              
  Lines         10564    10564              
  Branches       1415     1415              
============================================
- Hits           5169     5143      -26     
- Misses         4560     4580      +20     
- Partials        835      841       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gouri-panda gouri-panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kelson42 kelson42 merged commit fff9991 into main Dec 28, 2023
9 checks passed
@kelson42 kelson42 deleted the Issue#3640 branch December 28, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google play store showing error while uploading the APK.
3 participants