Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2532 Video seeking does not work anymore with 3.4.2 #2543

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

macgills
Copy link
Contributor

@macgills macgills commented Dec 9, 2020

Fixes #2532

  • readd range headers

@macgills macgills requested review from mhutti1 and abdulwd December 9, 2020 10:25
@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #2543 (3388142) into develop (7326257) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2543      +/-   ##
=============================================
- Coverage      39.12%   39.05%   -0.08%     
  Complexity        31       31              
=============================================
  Files            286      286              
  Lines           7322     7331       +9     
  Branches         893      895       +2     
=============================================
- Hits            2865     2863       -2     
- Misses          4163     4172       +9     
- Partials         294      296       +2     
Impacted Files Coverage Δ Complexity Δ
...kiwix/kiwixmobile/core/ServiceWorkerInitialiser.kt 33.33% <0.00%> (ø) 0.00 <0.00> (ø)
...kiwix/kiwixmobile/core/main/CoreWebViewClient.java 17.24% <0.00%> (ø) 0.00 <0.00> (ø)
...va/org/kiwix/kiwixmobile/core/main/KiwixWebView.kt 38.37% <0.00%> (ø) 0.00 <0.00> (ø)
...iwix/kiwixmobile/core/reader/ZimReaderContainer.kt 7.31% <0.00%> (-2.06%) 0.00 <0.00> (ø)
...iwix/kiwixmobile/core/main/CoreReaderFragment.java 24.40% <0.00%> (-0.27%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7326257...3388142. Read the comment docs.

@kelson42 kelson42 merged commit cd016c4 into develop Dec 9, 2020
@kelson42 kelson42 deleted the feature/macgills/2532-video-seeking branch December 9, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video seeking does not work anymore with 3.4.2
4 participants