Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2303 Impossible to surf on 3D printing SE ZIM file #2494

Merged

Conversation

macgills
Copy link
Contributor

Fixes #2303

  • opening a zim file unregisters before loading

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #2494 (b5672c6) into develop (17b71ab) will increase coverage by 0.35%.
The diff coverage is 34.37%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2494      +/-   ##
=============================================
+ Coverage      38.76%   39.12%   +0.35%     
  Complexity        31       31              
=============================================
  Files            285      286       +1     
  Lines           7295     7302       +7     
  Branches         887      890       +3     
=============================================
+ Hits            2828     2857      +29     
+ Misses          4174     4149      -25     
- Partials         293      296       +3     
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/org/kiwix/kiwixmobile/core/CoreApp.kt 64.81% <0.00%> (-1.23%) 0.00 <0.00> (ø)
...kiwix/kiwixmobile/core/main/CoreWebViewClient.java 17.24% <0.00%> (+0.84%) 0.00 <0.00> (ø)
...org/kiwix/kiwixmobile/core/reader/ZimFileReader.kt 3.44% <0.00%> (-0.13%) 0.00 <0.00> (ø)
...iwix/kiwixmobile/core/main/CoreReaderFragment.java 24.40% <53.33%> (+1.38%) 0.00 <0.00> (ø)
...iwixmobile/core/main/ServiceWorkerUninitialiser.kt 66.66% <66.66%> (ø) 0.00 <0.00> (?)
...iwix/kiwixmobile/core/reader/ZimReaderContainer.kt 9.37% <100.00%> (ø) 0.00 <0.00> (ø)
...rg/kiwix/kiwixmobile/core/main/CoreMainActivity.kt 49.12% <0.00%> (+2.63%) 0.00% <0.00%> (ø%)
.../kiwix/kiwixmobile/core/main/TableDrawerAdapter.kt 43.90% <0.00%> (+7.31%) 0.00% <0.00%> (ø%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17b71ab...b5672c6. Read the comment docs.

@macgills macgills requested review from abdulwd and rgaudin November 23, 2020 10:21
@macgills macgills marked this pull request as ready for review November 23, 2020 10:22
@macgills
Copy link
Contributor Author

@abdulwd finally have this fixed, if there are any obstacles to reviewing please let me know

@macgills macgills merged commit 4f60b71 into develop Nov 27, 2020
@macgills macgills deleted the feature3/macgills/2303-service-worker-unregistration branch November 27, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to surf on 3D printing SE ZIM file
3 participants