Skip to content

Conversation

@mgautierfr
Copy link
Contributor

@mgautierfr mgautierfr commented Feb 19, 2024

This PR is in Draft as it wrap a feature in libkiwix not yet released.
Once libkiwix is release, we have still have to change gradle script to use it and then we should be good.

Fix #84

@kelson42 kelson42 force-pushed the bookmarks_migrations branch from ab0cdbf to 58bff5f Compare February 25, 2024 15:39
@kelson42
Copy link
Contributor

@mgautierfr I have updated the code base to rely on libkiwix 13.1.0 and rebased this PR.

@codecov
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (1aeb144) to head (fa44690).

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #85      +/-   ##
============================================
+ Coverage     92.51%   92.85%   +0.34%     
- Complexity      218      232      +14     
============================================
  Files            45       46       +1     
  Lines           294      308      +14     
  Branches          3        3              
============================================
+ Hits            272      286      +14     
  Misses           19       19              
  Partials          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- setBookName, getBookName
- setBookFlavour, getBookFlavour
- migrateBookmarks
- getBestTargetBookId
@mgautierfr mgautierfr marked this pull request as ready for review February 26, 2024 12:51
@mgautierfr mgautierfr merged commit 0e6ef84 into main Feb 26, 2024
@mgautierfr mgautierfr deleted the bookmarks_migrations branch February 26, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support of libkiwix 13.1.0

2 participants