Building libzim & libkiwix for Android with debug symbols. #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The `.so` files were being stripped during the build process, which caused the debug symbols to be removed from our wrapper bindings. We have updated our Gradle configuration to prevent stripping, and as a result, our generated `.aar` now includes the debug symbols.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
=========================================
Coverage 93.23% 93.23%
Complexity 237 237
=========================================
Files 47 47
Lines 325 325
Branches 3 3
=========================================
Hits 303 303
Misses 19 19
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…recated `doNotStrip` with `keepDebugSymbols`.
Contributor
|
Merging to move forward, @veloman-yunkan can still tell us if there is a serious problem here afterward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121
The
.sofiles were being stripped during the build process, which caused the debug symbols to be removed from our wrapper bindings. We have updated our Gradle configuration to prevent stripping, and as a result, our generated.aarnow includes the debug symbols.