2 duration fields in TestCase class #1923

atodorov · 2020-09-16T17:04:17Z

Kiwi TCMS needs additional fields for the TestCase class. This is a prerequisite for time tracking features & telemetry some of which is described at https://kiwitcms.org/blog/kiwi-tcms-team/2019/03/03/legacy-reports-become-telemetry/.

Definition of Done:

New field TestCase.setup_duration of type DurationField(db_index=True, null=True, blank=True)
New field TestCase.testing_duration of type DurationField(db_index=True, null=True, blank=True)
New property TestCase.expected_duration - the sum of the previous 2 fields
All 3 fields shown in the testcases/get.html
get.html shows the 3 fields in a human readable format - will probably need a custom template filter to print in a format like "6 minutes" - NOTE: https://github.com/sookasa/django-timedelta-field/blob/master/timedelta/helpers.py will help but copying verbatim has many implications and we can leave this until the end.
setup_duration & testing_duration are added in testcases/mutable.html and can be editted
API methods TestCase.create & TestCase.update allow storing values for these fields - tests are updated to match
API method TestCase.filter returns the value of all 3 fields - tests are updated to match
All 3 fields are available as filters in the /cases/search/ page - special care should be taken for handling filtering by expected_duration, see https://docs.djangoproject.com/en/3.1/ref/models/expressions/#using-f-with-annotations

Note: when DurationField type is used in forms it doesn't have a nice widget so something like
https://github.com/koss-lebedev/bootstrap-duration-picker will probably work. Could be different if there is something nicer.

Test coverage for all of the related changes. This means both positive/negative scenarios where this makes sense or scenarios which traverse different branches of the code where that makes sense.
test class/test method names are descriptive and reflect the behavior of the subject under test. A good scheme to follow is Test<ClassUnderTest>.test_[who][what][expected_results]
CI pass
All code review passed & PR merged

Hints:

Coverage report is at https://codecov.io/gh/kiwitcms/Kiwi/tree/master/tcms
Devel getting started docs: https://kiwitcms.readthedocs.io/en/latest/contribution.html#testing
Django testing documentation: https://docs.djangoproject.com/en/3.0/topics/testing/

This issue is part of Kiwi TCMS open source bounty program. For more information see the link(s) in bounty-program milestone

The text was updated successfully, but these errors were encountered:

atodorov · 2020-09-18T10:44:29Z

Related
9348d74,
a43d5a1,
6f0483a,
083e3cd,

git log & search for estimated - there are a few more

840fa03 - timedelta2seconds

gasharova · 2021-02-11T20:34:15Z

Hello, I'm one of the MLH fellows and I'd like to start with this issue if possible. Awaiting assignment. Thank you in advance.

This commit is part of the issue kiwitcms#1924 where Kiwi TCMS needs additional fields for the TestExecution class. This is a prerequisite for time tracking features & telemetry. Here are the changes that this commit is trying to make: - New field TestExecution.start_date of type DateTimeField(db_index=True, null=True, blank=True) - Renamed the TestExecution.close_date to TestExecution.stop_date and add db_index=True - Added a new property TestExecution.actual_duration - the difference between the 2 fields - Added a new property TestExecution.expected_duration -> self.case.expected_duration; for convenience, see kiwitcms#1923 - API method TestExecution.update() supports the new start_date and close_ date fields

- Migration file symbol fixes via black - Added three fields in testcase view (get.html) - Added two fields in testcase add & edit view

- Displays fields directly from objects into get.html - Removed todos - Fixed duplicate line

- `setup_duration` and `testing_duration` now defaultly nulled until API calls are implemented - `expected_duration` default return 0 as property for same reason

…iwitcms#1923

- Test case for random durations being summed - Test case for an empty setup_duration field OR empty testing_duration field - Test case for both setup_duration AND testing_duration fields being empty

- Migration file symbol fixes via black - Added three fields in testcase view (get.html) - Added two fields in testcase add & edit view

- Displays fields directly from objects into get.html - Removed todos - Fixed duplicate line

- `setup_duration` and `testing_duration` now defaultly nulled until API calls are implemented - `expected_duration` default return 0 as property for same reason

…iwitcms#1923

- Test case for random durations being summed - Test case for an empty setup_duration field OR empty testing_duration field - Test case for both setup_duration AND testing_duration fields being empty

Add fields and the migration Added three fields in models.py: - setup_duration - testing_duration - expected_duration (property deco) Added new migration to reflect the 2 new duration fields - Added migration file 0018_add_testcase_duration_fiels.py - Reflected fields are setup_duration and testing_duration - The affected models are Testcase and Historicaltestcase Fixes lint failures and adds fields to templates kiwitcms#1923 - Migration file symbol fixes via black - Added three fields in testcase view (get.html) - Added two fields in testcase add & edit view Displaying duration fields in testcase.get kiwitcms#1923 - Displays fields directly from objects into get.html - Removed todos - Fixed duplicate line Fixes empty fields bug for merge into master kiwitcms#1923 - `setup_duration` and `testing_duration` now defaultly nulled until API calls are implemented - `expected_duration` default return 0 as property for same reason Modified expected_duration property to reflect business logic better kiwitcms#1923

- Test case for random durations being summed - Test case for an empty setup_duration field OR empty testing_duration field - Test case for both setup_duration AND testing_duration fields being empty

- setup_duration & testing_duration are added in testcases/mutable.html and can be editted

…1923

atodorov · 2021-09-06T17:48:07Z

CC @mfonism, please see the remaining sub-tasks here.

Refs kiwitcms#1923

…estcase Refs kiwitcms#1923

Refs #1923

…estcase Refs #1923

The API method `TestCase.filter` is extended to work for queries that contain lookups on the fields `setup_duration`, `testing_duration` and `expected_duration`. It also returns the values of all three fields in its result. Refs kiwitcms#1923

Refs kiwitcms#1923

The API method `TestCase.filter` is extended to work for queries that contain lookups on the fields `setup_duration`, `testing_duration` and `expected_duration`. It also returns the values of all three fields in its result. Refs kiwitcms#1923

Refs kiwitcms#1923

New fields: setup_duration, testing_duration, expected_duration - all serialized in seconds.

… page Refs kiwitcms#1923

atodorov added feature request € 25 bounty See bounty-program milestone labels Sep 16, 2020

atodorov added this to the bounty-program milestone Sep 16, 2020

This was referenced Sep 16, 2020

2 timestamp fields in TestExecution class #1924

Closed

Feature: Telemetry: actual vs. estimated duration for test execution #1927

Open

atodorov assigned gasharova Feb 11, 2021

atodorov added the MLH Fellowship https://fellowship.mlh.io/programs/open-source label Feb 11, 2021

atodorov mentioned this issue Feb 11, 2021

Angelina: 2 duration fields in TestCase class #1923 MLH-Fellowship/Kiwi#113

Open

APiligrim mentioned this issue Feb 16, 2021

Subject: 2 timestamp fields in TestExecution class #1924 #2251

Merged

gasharova mentioned this issue Feb 16, 2021

2 duration fields in Testcase class #2253

Closed

gasharova added a commit to MLH-Fellowship/Kiwi that referenced this issue Mar 1, 2021

Fixes lint failures and adds fields to templates kiwitcms#1923

a6b881c

- Migration file symbol fixes via black - Added three fields in testcase view (get.html) - Added two fields in testcase add & edit view

gasharova added a commit to MLH-Fellowship/Kiwi that referenced this issue Mar 3, 2021

Displaying duration fields in testcase.get kiwitcms#1923

00b0da3

- Displays fields directly from objects into get.html - Removed todos - Fixed duplicate line

gasharova added a commit to MLH-Fellowship/Kiwi that referenced this issue Mar 5, 2021

Modified expected_duration property to reflect business logic better k…

1157433

…iwitcms#1923

APiligrim pushed a commit to MLH-Fellowship/Kiwi that referenced this issue Mar 24, 2021

Displaying duration fields in testcase.get kiwitcms#1923

42a6ad1

- Displays fields directly from objects into get.html - Removed todos - Fixed duplicate line

APiligrim pushed a commit to MLH-Fellowship/Kiwi that referenced this issue Mar 24, 2021

Modified expected_duration property to reflect business logic better k…

7e4e9fd

…iwitcms#1923

APiligrim added a commit to MLH-Fellowship/Kiwi that referenced this issue Apr 16, 2021

Added: 2 New fields in test cases templates Refs. kiwitcms#1923

f00e125

- setup_duration & testing_duration are added in testcases/mutable.html and can be editted

APiligrim added a commit to MLH-Fellowship/Kiwi that referenced this issue Apr 22, 2021

Added: 2 New fields in test cases templates Refs. kiwitcms#1923

2e8283c

- setup_duration & testing_duration are added in testcases/mutable.html and can be editted

APiligrim added a commit to MLH-Fellowship/Kiwi that referenced this issue Apr 24, 2021

Added: 2 New fields in test cases templates Refs. kiwitcms#1923

c98d95f

- setup_duration & testing_duration are added in testcases/mutable.html and can be editted

APiligrim added a commit to MLH-Fellowship/Kiwi that referenced this issue Apr 30, 2021

Added: 2 New fields in test cases templates Refs. kiwitcms#1923

38cc980

- setup_duration & testing_duration are added in testcases/mutable.html and can be editted

APiligrim added a commit to MLH-Fellowship/Kiwi that referenced this issue May 4, 2021

Added: 2 New fields in test cases templates Refs. kiwitcms#1923

4718beb

- setup_duration & testing_duration are added in testcases/mutable.html and can be editted

APiligrim added a commit to MLH-Fellowship/Kiwi that referenced this issue May 4, 2021

Added: 2 New fields in test cases templates Refs. kiwitcms#1923

02eae70

- setup_duration & testing_duration are added in testcases/mutable.html and can be editted

APiligrim added a commit to MLH-Fellowship/Kiwi that referenced this issue May 4, 2021

Added: 2 New fields in test cases templates Refs. kiwitcms#1923

38c8188

- setup_duration & testing_duration are added in testcases/mutable.html and can be editted

APiligrim added a commit to MLH-Fellowship/Kiwi that referenced this issue May 4, 2021

Added: 2 New fields in test cases templates Refs. kiwitcms#1923

516b2d1

- setup_duration & testing_duration are added in testcases/mutable.html and can be editted

atodorov pushed a commit that referenced this issue Jul 6, 2021

Add setup_duration & testing_duration in testcases/mutable.html, Refs #…

3529805

…1923

atodorov pushed a commit that referenced this issue Jul 7, 2021

Add setup_duration & testing_duration in testcases/mutable.html, Refs #…

a2c3d3d

…1923

atodorov pushed a commit that referenced this issue Jul 7, 2021

Add setup_duration & testing_duration in testcases/mutable.html, Refs #…

dba12da

…1923

mfonism added a commit to mfonism/Kiwi that referenced this issue Sep 14, 2021

(api) Store setup_duration and testing_duration on creating testcase

aab4c09

Refs kiwitcms#1923

mfonism mentioned this issue Sep 14, 2021

Store setup_duration and testing_duration values on creating testcase #2524

Merged

mfonism added a commit to mfonism/Kiwi that referenced this issue Sep 15, 2021

(api) Update setup_duration and testing_duration fields on updating t…

e0f17fd

…estcase Refs kiwitcms#1923

atodorov pushed a commit that referenced this issue Sep 16, 2021

(api) Store setup_duration and testing_duration on creating testcase

7d0b689

Refs #1923

atodorov pushed a commit that referenced this issue Sep 16, 2021

(api) Update setup_duration and testing_duration fields on updating t…

af3d189

…estcase Refs #1923

mfonism mentioned this issue Sep 16, 2021

Make testcase filtering on the API side aware of the duration fields #2530

Open

mfonism mentioned this issue Sep 16, 2021

Ensure testcase filtering on the API side returns the three duration fields #2531

Merged

mfonism added a commit to mfonism/Kiwi that referenced this issue Sep 17, 2021

(api) Cast duration field values to floats in the database

fd19d31

Refs kiwitcms#1923

mfonism added a commit to mfonism/Kiwi that referenced this issue Sep 21, 2021

(api) Cast duration field values to floats in the database

baa60d9

Refs kiwitcms#1923

mfonism added a commit to mfonism/Kiwi that referenced this issue Oct 11, 2021

(api) Make testcase filtering aware of the duration fields

ccae5f5

Refs kiwitcms#1923

mfonism added a commit to mfonism/Kiwi that referenced this issue Oct 11, 2021

(api) Make testcase filtering aware of the duration fields

97ea6cd

Refs kiwitcms#1923

atodorov pushed a commit that referenced this issue Oct 11, 2021

[api]: TestCase.filter() method now returns duration fields. Refs #1923

2aabe55

New fields: setup_duration, testing_duration, expected_duration - all serialized in seconds.

mfonism added a commit to mfonism/Kiwi that referenced this issue Oct 15, 2021

(api) Make duration fields available as filters in the /cases/search/…

40e85d2

… page Refs kiwitcms#1923

mfonism mentioned this issue Oct 15, 2021

(api) Make duration fields available as filters in the /cases/search/ page #2558

Open

mfonism added a commit to mfonism/Kiwi that referenced this issue Oct 15, 2021

(api) Make duration fields available as filters in the /cases/search/…

6b557fe

… page Refs kiwitcms#1923

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2 duration fields in TestCase class #1923

2 duration fields in TestCase class #1923

atodorov commented Sep 16, 2020 •

edited

Loading

atodorov commented Sep 18, 2020

gasharova commented Feb 11, 2021

atodorov commented Sep 6, 2021

2 duration fields in TestCase class #1923

2 duration fields in TestCase class #1923

Comments

atodorov commented Sep 16, 2020 • edited Loading

atodorov commented Sep 18, 2020

gasharova commented Feb 11, 2021

atodorov commented Sep 6, 2021

atodorov commented Sep 16, 2020 •

edited

Loading