Add support for url download #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @aslafy-z , thank you for your PR. I recently merged a PR to make the sidecar container usable as an init container. If you could update your PR to cover that use case too, I would really appreciate it. |
|
@Tim-Smyth I made a fix for this, it doubles the code from now. Haven't got the time to make it better.. |
pulledtim
reviewed
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR help to solve the problem described in this issue: https://github.com/coreos/prometheus-operator/issues/2033
Usecases:
A test image can be found here: zadki3l/k8s-sidecar:download-url-support