update: numpy, pandas, sdl2
#3164
Conversation
T-Dynamos
force-pushed
the
numpy-update
branch
4 times, most recently
from
40f08b6 to
a09a2b3
Compare
T-Dynamos
force-pushed
the
numpy-update
branch
2 times, most recently
from
e950baa to
1cd30ca
Compare
|
Ready for review. Hope it can be merged soon! (One action failed, probably due to an internet connection error) |
| def download_if_necessary(self): | ||
| if self.ctx.ndk_api < self.min_ndk_api_support: | ||
| error(f"In order to build '{self.name}', you must set minimum ndk api (minapi) to `{self.min_ndk_api_support}`.\n") | ||
| exit(1) |
There was a problem hiding this comment.
Wait, shouldn't we leverage pythonforandroid/recommendations.py?
Maybe @misl6 has better insights
| url = 'git+https://github.com/numpy/numpy' | ||
| hostpython_prerequisites = ["Cython>=3.0.6"] # meson does not detects venv's cython | ||
| hostpython_prerequisites = ["Cython==3.0.6"] # meson does not detects venv's cython |
There was a problem hiding this comment.
Do we have to be that restrictive? Maybe it doesn't work with too recents Cython versions, but in this case maybe we should use a range at least
| def download_if_necessary(self): | ||
| # NumPy requires complex math functions which were added in api 24 | ||
| if self.ctx.ndk_api < 24: | ||
| error(NUMPY_NDK_MESSAGE) | ||
| exit(1) | ||
| super().download_if_necessary() |
There was a problem hiding this comment.
Oh OK I see what you did there by moving it to recipe.py
@misl6 would have better insights, but I'd be tempted to keep it in this recipe only for this PR unless we have a clearly cleaner approach, what do you guys think?
There was a problem hiding this comment.
I did this because it was also required in scipy recipe.
Closes #3163
Split #3136