Support Android resources similarly to assets #2299
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerela
force-pushed
the
support_resources
branch
from
bcce4ba to
62452bb
Compare
lerela
force-pushed
the
support_resources
branch
from
62452bb to
7e2eae1
Compare
lerela
commented
Aug 14, 2020
| for res in args.resources: | ||
| res_src, res_dest = res.split(":") | ||
| if isfile(realpath(res_src)): | ||
| ensure_dir(dirname(join(res_dir, res_dest))) |
There was a problem hiding this comment.
This is obviously redundant with the assets copying logic just above, and could be factorized if needed
|
I think you forgot to expose this functionality in toolchain.py. |
Merged
|
Superseded by #2684 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2298
This PR allows adding a resource to the Android resources folder exactly as an asset. Difference with assets is that resources can subsequently be instantiated as Drawables:
This is especially useful to pick a notification icon that respect the new Android requirements (PNG with white shape on transparent background) instead of using the app icon, which gets rendered as a white square on many recent devices. I could not find an easy way to do so with an asset.