feat: disable showing sdk manager progress #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has no quiet mode and causes between 10 and 100 MEGABYTES of log spam. I mean c'mon. So let's just discard all of that using a simple grep vanish
…ndroid_update_sdk
|
Fixes #837 |
AndreMiras
reviewed
Mar 29, 2019
| if "CI" in environ: | ||
| sdkmanager_commands = list(sdkmanager_commands) | ||
| sdkmanager_commands.insert(len(sdkmanager_commands), '>/dev/null') # mute stdout, important stuff goes to stderr anyways | ||
| sdkmanager_commands = tuple(sdkmanager_commands) |
There was a problem hiding this comment.
why not skipping this whole part since you already introduced the grep -v "^\\[" fix in the _sdkmanager() method above?
AndreMiras
reviewed
Mar 29, 2019
| if "CI" in environ and ">/dev/null" not in args: | ||
| args = list(args) | ||
| args.insert(len(args), ' | grep -v "^\\["') | ||
| args = tuple(args) | ||
| command = self.sdkmanager_path + ' ' + ' '.join(args) |
There was a problem hiding this comment.
Instead if this 4 lines of code "adding" the grep o the args. I think it would be more simple to go after the command = self.sdkmanager_path + ' ' + ' '.join(args) line and to do something like:
if 'CI' in environ:
# hide download lines which look like "[= ] 10% Downloading platform-tools"
command += r' | grep -v "^\["'
Also note that I've used a raw-string to make the grep expression more readable (by skipping the double escaping of the \).
Last I've added a little code comment because it's not super obvious what we are doing
AndreMiras
requested changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has no quiet mode and causes between 10 and 100 MEGABYTES of log
spam. I mean c'mon.
So let's just discard all of that using a simple grep vanish