Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Osx Target to properly use buildozer.buildops #1768

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fix Osx Target to properly use buildozer.buildops #1768

merged 1 commit into from
Jan 30, 2024

Conversation

akshayaurora
Copy link
Member

OSX Target was incorrectly using buildozer.buildops

@akshayaurora
Fix Osx Target to properly use buildozer.buildops
18f35df 
OSX Target was incorrectly using buildozer.buildops
Julian-O
Julian-O approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@Julian-O Julian-O left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still concerned there is no integration test that would have captured these problems.

@Julian-O
Copy link
Contributor

Fixes #1758 (and more)

@akshayaurora akshayaurora merged commit 42612b6 into master Jan 30, 2024
4 of 30 checks passed
@akshayaurora akshayaurora deleted the osx_target_buildops_fix branch January 30, 2024 15:16
@misl6 misl6 mentioned this pull request Mar 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julian-O Julian-O Julian-O approved these changes

@misl6 misl6 Awaiting requested review from misl6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akshayaurora @Julian-O