Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed the mobile view #17

Merged
merged 4 commits into from
Mar 28, 2023
Merged

fix: fixed the mobile view #17

merged 4 commits into from
Mar 28, 2023

Conversation

gustensund
Copy link
Contributor

@gustensund gustensund commented Mar 21, 2023

Updated the mobile view. This required several minor tweaks to some components.

Please note that since we NOW hide the navbar as default when on mobile view. This means that our start screen when viewing from a mobile device will look like a white screen with only a hamburger menu in the top right corner. This isn't something we should fix in this pr. We should edit /, (maybe add some text) this would fix that "problem".

Feel free to pull the branch and try it out locally.

Start screen:
image

New story look on mobile:
Screenshot 2023-03-21 at 16 50 47

Screen.Recording.2023-03-21.at.16.51.22.mov

@gustensund gustensund requested a review from a team March 21, 2023 16:03
Copy link
Contributor

@kivra-erilin kivra-erilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Two things:

  • Since this relates to mobile view, can we also check if we can fix the JS errors on iOS?

image

  • How about dimming out the non-sidebar content when mobile sidebar is visible? If too much work probably not worth it :)

@gustensund
Copy link
Contributor Author

Very nice! Two things:

  • Since this relates to mobile view, can we also check if we can fix the JS errors on iOS?

image

  • How about dimming out the non-sidebar content when mobile sidebar is visible? If too much work probably not worth it :)

fixed dimmed background in 968a8cf

@gustensund gustensund merged commit 3da2134 into main Mar 28, 2023
@gustensund gustensund deleted the fix/mobile-view branch March 28, 2023 13:22
@github-actions
Copy link

🎉 This PR is included in version 1.6.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants