-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/inplace: add new parameter --inplace
(-i
) for in-place formatting
#377
Conversation
Resolves kivikakk#376
Thank you, this looks excellent. I really appreciate the extra clippy fixes! I know in the past that some of these changes caused issues for people because it caused an increase in the MSRV (see #290), but I think it's been long enough that I'm happy to move on. Still, before I merge, I'm going to compare the lib and bin MSRVs before and after this change, just for my own reference, and make an appropriate declaration in Cargo.toml. Thank you again! 🤍 |
OK! Now we get an MSRV of 1.62.1, compared with 1.60.0 on main. This seems completely fine to me — thanks again! |
@bioinformatist just curious, is there any difference between
and
It seems to work the same for me 🤔 |
It is the same, and it should be! And it's fine for it to be 👍 We could expand |
Sounds good to me. One thought I had was if the option was set we might be able to just set the proper |
Some clippy lints also have been fixed separately 😺