Misc estimator fixes #161
Merged
Misc estimator fixes #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I wonder why the git fetch fails on travis - I will try restarting it. |
timokau
force-pushed
the
misc-estimator-fixes
branch
from
52fff17 to
685cdb7
Compare
Owner
|
Seems to have fixed itself. |
kiudee
previously approved these changes
Sep 26, 2020
Merge can only be called on multiple layers, and in the case of length-one rankings there will only be one layer.
Required by the scikit-learn estimator API for easier fit-predict chaining.
This would previously fail due to a division by 0 if the ranking is 0-based and consists of only one object. Concretely, this would fail the "check_fit2d_1sample" check from the scikit-learn estimator test suite if we generate 0-based rankings.
timokau
force-pushed
the
misc-estimator-fixes
branch
from
685cdb7 to
47d8f6a
Compare
Collaborator
Author
|
For some reason GitHub told me the branch is outdated, even though there were no conflicts. So I did a trivial rebase, please re-approve. |
kiudee
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleaning up & pulling out this weeks changes from #116.
Motivation and Context
I'm trying to avoid piling up too many unreviewed "fixup" commits in #116. These changes are ready now, so I think its better to get them in now.
How Has This Been Tested?
Ran the pre-commit checks and the test suite for every commit.
Does this close/impact existing issues?
Impacts #94.
Types of changes
Checklist: