Fix javadoc errors and warnings for Kitodo-API #6162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After these fixes, the next errors and warnings are reported for Kitodo-DataManagement. |
Kitodo-API/src/main/java/org/kitodo/api/dataformat/MediaPartial.java
Outdated
Show resolved
Hide resolved
stweil
commented
Jul 31, 2024
Kitodo-API/src/main/java/org/kitodo/api/dataformat/MediaPartial.java
Outdated
Show resolved
Hide resolved
Kitodo-API/src/main/java/org/kitodo/api/dataformat/MediaPartial.java
Outdated
Show resolved
Hide resolved
Kitodo-API/src/main/java/org/kitodo/api/dataformat/MediaPartial.java
Outdated
Show resolved
Hide resolved
|
Can this PR be merged? Then I could work on the Javadoc warnings and errors for other modules of Kitodo. |
stweil
commented
Sep 2, 2024
Kitodo-API/src/main/java/org/kitodo/api/dataformat/MediaPartial.java
Outdated
Show resolved
Hide resolved
Kitodo-API/src/main/java/org/kitodo/api/dataformat/MediaPartial.java
Outdated
Show resolved
Hide resolved
Kitodo-API/src/main/java/org/kitodo/api/dataformat/MediaPartial.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Suggested-by: Henning Gerhardt <henning.gerhardt@slub-dresden.de> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
|
Many of the other javadoc errors are similar to this one: Do you have a suggestion how this should be fixed? Would using "→" be okay? |
|
How can we proceed with this topic? |
|
@solth, is there still anything that prevents this PR from being merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially fixes issue #6161.