Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(limit): support limit config #30

Merged
merged 9 commits into from
May 10, 2024

Conversation

whalecold
Copy link
Member

@whalecold whalecold commented Mar 11, 2024

What type of PR is this?

feat(limit): support limit config

What this PR does / why we need it (en: English/zh: Chinese):

en:
zh:支持服务端限流

Which issue(s) this PR fixes:

#28

@whalecold whalecold force-pushed the feat/limit branch 4 times, most recently from da388a4 to a404cea Compare March 11, 2024 11:54
@whalecold whalecold changed the title WIP: feat(limit): support limit config feat(limit): support limit config Mar 11, 2024
@whalecold whalecold force-pushed the feat/limit branch 3 times, most recently from 318535b to 76d6cee Compare March 11, 2024 14:06
@ppzqh ppzqh self-assigned this Mar 12, 2024
core/manager/manager.go Outdated Show resolved Hide resolved
core/manager/manager.go Outdated Show resolved Hide resolved
core/manager/client.go Outdated Show resolved Hide resolved
@whalecold whalecold force-pushed the feat/limit branch 2 times, most recently from 1b2b44d to 7cf1733 Compare March 12, 2024 02:32
xdssuite/xds.go Outdated Show resolved Hide resolved
@whalecold whalecold force-pushed the feat/limit branch 5 times, most recently from b9ec6d3 to b703928 Compare March 12, 2024 10:02
Copy link
Member

@CoderPoet CoderPoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ppzqh
Copy link
Contributor

ppzqh commented May 10, 2024

/LGTM

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CoderPoet, ppzqh, whalecold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bytedance-oss-robot bytedance-oss-robot bot merged commit fd3d5a5 into kitex-contrib:main May 10, 2024
11 checks passed
@whalecold whalecold deleted the feat/limit branch May 13, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants