generated from cloudwego/.github
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Most realisations of ymlloader and some realisations of etcdloader #1
Open
Printemps417
wants to merge
30
commits into
kitex-contrib:main
Choose a base branch
from
Printemps417:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
d7d1de7
v2
Printemps417 fa4a621
infra change
Printemps417 3b3434d
yml_define
Printemps417 8935e52
reader partly done
Printemps417 e73b73c
loader1
Printemps417 17b61dd
some translator
Printemps417 8bb29b1
check
Printemps417 d5ce82a
Update decoder.go
Printemps417 713c8d2
demo
Printemps417 3c2b70c
first commit
zhu-mi-shan 8eee28d
PR1
Printemps417 20dd894
update etcd client
zhu-mi-shan 2070eda
Merge branch 'etcd'
zhu-mi-shan d9f8b32
add etcd client suite
zhu-mi-shan b90481d
Merge branch 'etcd'
zhu-mi-shan 13c2c15
add etcd server
zhu-mi-shan d90e5b2
Merge branch 'etcd'
zhu-mi-shan 87f2c8d
update
zhu-mi-shan 9eb4226
update package name
zhu-mi-shan 266977f
test examples
zhu-mi-shan 184fb79
Merge branch 'etcd'
zhu-mi-shan f71d43d
update
zhu-mi-shan bfb0e33
Merge branch 'etcd'
zhu-mi-shan 9e24308
fix server decoder
zhu-mi-shan 76450e6
Merge branch 'etcd'
zhu-mi-shan 93ddf39
init commit
zhu-mi-shan 84dfa58
update client
zhu-mi-shan 9a7b853
update server
zhu-mi-shan ac19adc
update example
zhu-mi-shan cddc26b
update go.mod
zhu-mi-shan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,40 +1,40 @@ | ||
--- | ||
name: Bug report | ||
about: Create a report to help us improve | ||
title: '' | ||
labels: '' | ||
assignees: '' | ||
|
||
--- | ||
|
||
**Describe the bug** | ||
|
||
A clear and concise description of what the bug is. | ||
|
||
**To Reproduce** | ||
|
||
Steps to reproduce the behavior: | ||
1. Go to '...' | ||
2. Click on '....' | ||
3. Scroll down to '....' | ||
4. See error | ||
|
||
**Expected behavior** | ||
|
||
A clear and concise description of what you expected to happen. | ||
|
||
**Screenshots** | ||
|
||
If applicable, add screenshots to help explain your problem. | ||
|
||
**Kitex version:** | ||
|
||
Please provide the version of Kitex you are using. | ||
|
||
**Environment:** | ||
|
||
The output of `go env`. | ||
|
||
**Additional context** | ||
|
||
Add any other context about the problem here. | ||
--- | ||
name: Bug report | ||
about: Create a report to help us improve | ||
title: '' | ||
labels: '' | ||
assignees: '' | ||
--- | ||
**Describe the bug** | ||
A clear and concise description of what the bug is. | ||
**To Reproduce** | ||
Steps to reproduce the behavior: | ||
1. Go to '...' | ||
2. Click on '....' | ||
3. Scroll down to '....' | ||
4. See error | ||
**Expected behavior** | ||
A clear and concise description of what you expected to happen. | ||
**Screenshots** | ||
If applicable, add screenshots to help explain your problem. | ||
**Kitex version:** | ||
Please provide the version of Kitex you are using. | ||
**Environment:** | ||
The output of `go env`. | ||
**Additional context** | ||
Add any other context about the problem here. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,24 @@ | ||
--- | ||
name: Feature request | ||
about: Suggest an idea for this project | ||
title: '' | ||
labels: '' | ||
assignees: '' | ||
|
||
--- | ||
|
||
**Is your feature request related to a problem? Please describe.** | ||
|
||
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] | ||
|
||
**Describe the solution you'd like** | ||
|
||
A clear and concise description of what you want to happen. | ||
|
||
**Describe alternatives you've considered** | ||
|
||
A clear and concise description of any alternative solutions or features you've considered. | ||
|
||
**Additional context** | ||
|
||
Add any other context or screenshots about the feature request here. | ||
--- | ||
name: Feature request | ||
about: Suggest an idea for this project | ||
title: '' | ||
labels: '' | ||
assignees: '' | ||
--- | ||
**Is your feature request related to a problem? Please describe.** | ||
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] | ||
**Describe the solution you'd like** | ||
A clear and concise description of what you want to happen. | ||
**Describe alternatives you've considered** | ||
A clear and concise description of any alternative solutions or features you've considered. | ||
**Additional context** | ||
Add any other context or screenshots about the feature request here. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,49 +1,49 @@ | ||
#### What type of PR is this? | ||
<!-- | ||
Add one of the following kinds: | ||
|
||
build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm) | ||
ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs) | ||
docs: Documentation only changes | ||
feat: A new feature | ||
optimize: A new optimization | ||
fix: A bug fix | ||
perf: A code change that improves performance | ||
refactor: A code change that neither fixes a bug nor adds a feature | ||
style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc) | ||
test: Adding missing tests or correcting existing tests | ||
chore: Changes to the build process or auxiliary tools and libraries such as documentation generation | ||
--> | ||
|
||
#### Check the PR title. | ||
<!-- | ||
The description of the title will be attached in Release Notes, | ||
so please describe it from user-oriented, what this PR does / why we need it. | ||
Please check your PR title with the below requirements: | ||
--> | ||
- [ ] This PR title match the format: \<type\>(optional scope): \<description\> | ||
- [ ] The description of this PR title is user-oriented and clear enough for others to understand. | ||
- [ ] Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. [User docs repo](https://github.com/cloudwego/cloudwego.github.io) | ||
|
||
|
||
#### (Optional) Translate the PR title into Chinese. | ||
|
||
|
||
#### (Optional) More detailed description for this PR(en: English/zh: Chinese). | ||
<!-- | ||
Provide more detailed info for review(e.g., it's recommended to provide perf data if this is a perf type PR). | ||
--> | ||
en: | ||
zh(optional): | ||
|
||
|
||
#### (Optional) Which issue(s) this PR fixes: | ||
<!-- | ||
Automatically closes linked issue when PR is merged. | ||
Eg: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. | ||
--> | ||
|
||
#### (optional) The PR that updates user documentation: | ||
<!-- | ||
If the current PR requires user awareness at the usage level, please submit a PR to update user docs. [User docs repo](https://github.com/cloudwego/cloudwego.github.io) | ||
--> | ||
#### What type of PR is this? | ||
<!-- | ||
Add one of the following kinds: | ||
build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm) | ||
ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs) | ||
docs: Documentation only changes | ||
feat: A new feature | ||
optimize: A new optimization | ||
fix: A bug fix | ||
perf: A code change that improves performance | ||
refactor: A code change that neither fixes a bug nor adds a feature | ||
style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc) | ||
test: Adding missing tests or correcting existing tests | ||
chore: Changes to the build process or auxiliary tools and libraries such as documentation generation | ||
--> | ||
#### Check the PR title. | ||
<!-- | ||
The description of the title will be attached in Release Notes, | ||
so please describe it from user-oriented, what this PR does / why we need it. | ||
Please check your PR title with the below requirements: | ||
--> | ||
- [ ] This PR title match the format: \<type\>(optional scope): \<description\> | ||
- [ ] The description of this PR title is user-oriented and clear enough for others to understand. | ||
- [ ] Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. [User docs repo](https://github.com/cloudwego/cloudwego.github.io) | ||
#### (Optional) Translate the PR title into Chinese. | ||
#### (Optional) More detailed description for this PR(en: English/zh: Chinese). | ||
<!-- | ||
Provide more detailed info for review(e.g., it's recommended to provide perf data if this is a perf type PR). | ||
--> | ||
en: | ||
zh(optional): | ||
#### (Optional) Which issue(s) this PR fixes: | ||
<!-- | ||
Automatically closes linked issue when PR is merged. | ||
Eg: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. | ||
--> | ||
#### (optional) The PR that updates user documentation: | ||
<!-- | ||
If the current PR requires user awareness at the usage level, please submit a PR to update user docs. [User docs repo](https://github.com/cloudwego/cloudwego.github.io) | ||
--> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,60 +1,60 @@ | ||
name: Pull Request Check | ||
|
||
on: [ pull_request ] | ||
|
||
jobs: | ||
compliant: | ||
runs-on: [ self-hosted, X64 ] | ||
steps: | ||
- uses: actions/checkout@v3 | ||
|
||
- name: Check License Header | ||
uses: apache/skywalking-eyes/header@v0.4.0 | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
- name: Check Spell | ||
uses: crate-ci/typos@master | ||
|
||
staticcheck: | ||
runs-on: [ self-hosted, X64 ] | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Set up Go | ||
uses: actions/setup-go@v3 | ||
with: | ||
go-version: "1.20" | ||
|
||
- uses: actions/cache@v3 | ||
with: | ||
path: ~/go/pkg/mod | ||
key: reviewdog-${{ runner.os }}-go-${{ hashFiles('**/go.sum') }} | ||
restore-keys: | | ||
reviewdog-${{ runner.os }}-go- | ||
|
||
- uses: reviewdog/action-staticcheck@v1 | ||
with: | ||
github_token: ${{ secrets.github_token }} | ||
# Change reviewdog reporter if you need [github-pr-check,github-check,github-pr-review]. | ||
reporter: github-pr-review | ||
# Report all results. | ||
filter_mode: nofilter | ||
# Exit with 1 when it find at least one finding. | ||
fail_on_error: true | ||
# Set staticcheck flags | ||
staticcheck_flags: -checks=inherit,-SA1029 | ||
|
||
lint: | ||
runs-on: [ self-hosted, X64 ] | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Set up Go | ||
uses: actions/setup-go@v3 | ||
with: | ||
go-version: "1.20" | ||
|
||
- name: Golangci Lint | ||
# https://golangci-lint.run/ | ||
uses: golangci/golangci-lint-action@v3 | ||
with: | ||
version: latest | ||
name: Pull Request Check | ||
on: [ pull_request ] | ||
jobs: | ||
compliant: | ||
runs-on: [ self-hosted, X64 ] | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Check License Header | ||
uses: apache/skywalking-eyes/header@v0.4.0 | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
- name: Check Spell | ||
uses: crate-ci/typos@master | ||
staticcheck: | ||
runs-on: [ self-hosted, X64 ] | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Set up Go | ||
uses: actions/setup-go@v3 | ||
with: | ||
go-version: "1.20" | ||
- uses: actions/cache@v3 | ||
with: | ||
path: ~/go/pkg/mod | ||
key: reviewdog-${{ runner.os }}-go-${{ hashFiles('**/go.sum') }} | ||
restore-keys: | | ||
reviewdog-${{ runner.os }}-go- | ||
- uses: reviewdog/action-staticcheck@v1 | ||
with: | ||
github_token: ${{ secrets.github_token }} | ||
# Change reviewdog reporter if you need [github-pr-check,github-check,github-pr-review]. | ||
reporter: github-pr-review | ||
# Report all results. | ||
filter_mode: nofilter | ||
# Exit with 1 when it find at least one finding. | ||
fail_on_error: true | ||
# Set staticcheck flags | ||
staticcheck_flags: -checks=inherit,-SA1029 | ||
lint: | ||
runs-on: [ self-hosted, X64 ] | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Set up Go | ||
uses: actions/setup-go@v3 | ||
with: | ||
go-version: "1.20" | ||
- name: Golangci Lint | ||
# https://golangci-lint.run/ | ||
uses: golangci/golangci-lint-action@v3 | ||
with: | ||
version: latest |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这是改了什么?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果只是 \n 被改成了 \r\n ,那就调整一下你们的 IDE 设置,这样没意义的修改会干扰 review 和后续的协作。