feat: add zookeeper && server #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
felix021
reviewed
Nov 14, 2023
felix021
reviewed
Nov 14, 2023
felix021
reviewed
Nov 14, 2023
felix021
reviewed
Nov 14, 2023
felix021
reviewed
Nov 14, 2023
felix021
reviewed
Nov 14, 2023
felix021
reviewed
Nov 14, 2023
|
client 的实现以及 readme 需要补充 @jiuxia211 |
|
cla 需要签一下 @jiuxia211 |
ViolaPioggia
suggested changes
Nov 24, 2023
XZ0730
reviewed
Nov 26, 2023
ozline
reviewed
Dec 1, 2023
li-jin-gou
requested changes
Dec 2, 2023
ViolaPioggia
reviewed
Dec 6, 2023
3 tasks
XZ0730
reviewed
Dec 6, 2023
XZ0730
reviewed
Dec 7, 2023
li-jin-gou
approved these changes
Dec 9, 2023
|
记得补充一个官网文档 @jiuxia211 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jiuxia211, li-jin-gou The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ZLPolaris
pushed a commit
to ZLPolaris/config-zookeeper
that referenced
this pull request
Jun 20, 2024
* feat: add zookeeper && server * update go mod * use gofumpt * fix: atomic.Int64 can't be used under go 1.19 * fix: unreasonable names * fix: update the processing of removed keys and empty data * style: add cancelFuncHolder type * style: update code comments * refactor: optimized loop variable * feat: add client * feat: update client * fix: add missing code snippet * feat: add README * style: use gofumpt * chore(doc): optimize readme * docs: update README * feat: add listen goroutine recover * fix: correct error logging format in project --------- Co-authored-by: kinggo <lilong.21@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
feat: add zookeeper && server
(Optional) Translate the PR title into Chinese.
增加 zookeeper初始化连接以及 server 端
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: [cloudwego/kitex#1165]
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: