Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add zookeeper && server #1

Merged
merged 19 commits into from
Dec 9, 2023
Merged

Conversation

jiuxia211
Copy link
Collaborator

@jiuxia211 jiuxia211 commented Nov 14, 2023

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo
    feat: add zookeeper && server

(Optional) Translate the PR title into Chinese.

增加 zookeeper初始化连接以及 server 端

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: [cloudwego/kitex#1165]
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@CLAassistant
Copy link

CLAassistant commented Nov 14, 2023

CLA assistant check
All committers have signed the CLA.

server/limiter.go Outdated Show resolved Hide resolved
zookeeper/zookeeper.go Outdated Show resolved Hide resolved
zookeeper/zookeeper.go Outdated Show resolved Hide resolved
zookeeper/parser.go Outdated Show resolved Hide resolved
zookeeper/zookeeper.go Outdated Show resolved Hide resolved
@li-jin-gou
Copy link
Contributor

li-jin-gou commented Nov 24, 2023

client 的实现以及 readme 需要补充 @jiuxia211

@li-jin-gou
Copy link
Contributor

cla 需要签一下 @jiuxia211

zookeeper/zookeeper.go Show resolved Hide resolved
zookeeper/parser.go Outdated Show resolved Hide resolved
example/server/main.go Outdated Show resolved Hide resolved
zookeeper/zookeeper.go Show resolved Hide resolved
zookeeper/zookeeper.go Show resolved Hide resolved
zookeeper/zookeeper.go Show resolved Hide resolved
example/go.mod Show resolved Hide resolved
Copy link
Contributor

@li-jin-gou li-jin-gou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client 的实现以及 readme 需要补充

README.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
zookeeper/zookeeper.go Show resolved Hide resolved
zookeeper/zookeeper.go Show resolved Hide resolved
zookeeper/zookeeper.go Outdated Show resolved Hide resolved
@li-jin-gou
Copy link
Contributor

记得补充一个官网文档 @jiuxia211

@li-jin-gou
Copy link
Contributor

/approve

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jiuxia211, li-jin-gou

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@li-jin-gou li-jin-gou merged commit a20b754 into kitex-contrib:main Dec 9, 2023
10 of 11 checks passed
ZLPolaris pushed a commit to ZLPolaris/config-zookeeper that referenced this pull request Jun 20, 2024
* feat: add zookeeper && server

* update go mod

* use gofumpt

* fix: atomic.Int64 can't be used under go 1.19

* fix: unreasonable names

* fix: update the processing of removed keys and empty data

* style: add cancelFuncHolder type

* style: update code comments

* refactor: optimized loop variable

* feat: add client

* feat: update client

* fix: add missing code snippet

* feat: add README

* style: use gofumpt

* chore(doc): optimize readme

* docs: update README

* feat: add listen goroutine recover

* fix: correct error logging format in project

---------

Co-authored-by: kinggo <lilong.21@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants