Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Nacos v2 SDK #23

Merged
merged 10 commits into from
Mar 3, 2024
Merged

Conversation

yuxialuozi
Copy link
Contributor

@yuxialuozi yuxialuozi commented Mar 2, 2024

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@CLAassistant
Copy link

CLAassistant commented Mar 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor Author

@yuxialuozi yuxialuozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

兼容了nacos-v2-go-sdk

@yuxialuozi yuxialuozi changed the title fix:兼容了nacos-v2-go-sdk add:兼容了nacos-v2-go-sdk Mar 2, 2024
Copy link
Contributor Author

@yuxialuozi yuxialuozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review成功

@yuxialuozi yuxialuozi changed the title add:兼容了nacos-v2-go-sdk [#22] add:兼容了nacos-v2-go-sdk Mar 2, 2024
@yuxialuozi yuxialuozi changed the title [#22] add:兼容了nacos-v2-go-sdk [#22] Feet:Add support for Nacos v2 SDK Mar 2, 2024
@yuxialuozi yuxialuozi changed the title [#22] Feet:Add support for Nacos v2 SDK [#22] feet:add support for Nacos v2 SDK Mar 2, 2024
@yuxialuozi yuxialuozi changed the title [#22] feet:add support for Nacos v2 SDK [#22] feet: add support for Nacos v2 SDK Mar 2, 2024
@yuxialuozi yuxialuozi changed the title [#22] feet: add support for Nacos v2 SDK [#22] feat: add support for Nacos v2 SDK Mar 2, 2024
@yuxialuozi yuxialuozi changed the title [#22] feat: add support for Nacos v2 SDK Add support for Nacos v2 SDK Mar 2, 2024
@li-jin-gou
Copy link
Contributor

V2 没有 readme 介绍

@li-jin-gou li-jin-gou force-pushed the v2-sdk branch 6 times, most recently from f57409a to 06f235d Compare March 3, 2024 15:02
@li-jin-gou li-jin-gou added the lgtm label Mar 3, 2024
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: li-jin-gou, yuxialuozi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@li-jin-gou li-jin-gou merged commit 698e368 into kitex-contrib:main Mar 3, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants