Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nacos): support reuse nacos client #11

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

whalecold
Copy link
Member

@whalecold whalecold commented Nov 1, 2023

What type of PR is this?

feature

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

#9

(optional) The PR that updates user documentation:

nacos/uid.go Show resolved Hide resolved
nacos/nacos.go Outdated Show resolved Hide resolved
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: felix021, whalecold

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@felix021 felix021 merged commit b2402c8 into kitex-contrib:main Nov 1, 2023
10 of 11 checks passed
@whalecold whalecold deleted the feat/client branch November 1, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants