Skip to content

Fix spacing between title and description in teaser block.(Breaking change) - #352

Merged
sneridagh merged 8 commits into
mainfrom
improve-teaser
Mar 6, 2024
Merged

sneridagh merged 8 commits into
mainfrom
improve-teaser

Conversation

@iFlameing

@iFlameing iFlameing commented Feb 29, 2024 •

Copy link
Copy Markdown
Member

Fixes #353

It is not a breaking changes but it might change the look of almost all the websites.

Screenshots.

Screenshot 2024-03-05 at 5 18 13 PM

@iFlameing iFlameing changed the title Remove border and fix some spacing in teaser block. Remove border and fix some spacing in teaser block.(Maybe Breaking change.) Feb 29, 2024
@iFlameing
iFlameing requested a review from sneridagh February 29, 2024 12:32
@iFlameing

Copy link
Copy Markdown
Member Author

@sneridagh Thomas bork our designer persisted with removing the border as well as reducing the space between teaser title and description. If you want to give feedback please reply in figma.

@iFlameing iFlameing self-assigned this Feb 29, 2024
@iFlameing iFlameing changed the title Remove border and fix some spacing in teaser block.(Maybe Breaking change.) Fix spacing between title and description in teaser block.(Breaking change) Mar 5, 2024
@iFlameing iFlameing added the bug Something isn't working label Mar 5, 2024
@iFlameing

Copy link
Copy Markdown
Member Author

@sneridagh I updated the code to only change the space. Where should I mention that it is a breaking change?

@sneridagh

Copy link
Copy Markdown
Member

@iFlameing ready

@sneridagh
sneridagh merged commit f7744a2 into main Mar 6, 2024
@sneridagh
sneridagh deleted the improve-teaser branch March 6, 2024 09:47
sneridagh added a commit that referenced this pull request Mar 11, 2024
* main: (21 commits)
  Remove @plone/volto peerDepencency (#364)
  Release 3.1.1
  Fix typo in container deprecation notice (#362)
  Release 3.1.0
  Safer pass by value instead of by reference when modifying internal `blockConfig` data (#361)
  Use the Container in @plone/components (#360)
  Fix spacing between title and description in teaser block.(Breaking change) (#352)
  Fix header tabbing order (#251) (#346)
  Fix show figcaption tag if ther is no caption (#350) (#351)
  Add eu and es translations (#358)
  Release 3.0.1
  Fix teaser styles on add form (#355)
  Missing versions from the last merged PR
  Update to Volto 17.15.1 (#348)
  Fix image gallery opacity. (#347)
  Release 3.0.0
  Add Event metadata block (#290)
  Fix missing key in header (#345)
  Add options to show intranet flag and intranet header. (#318)
  Fix A11y in Navigation (#344)
  ...
macagua pushed a commit to plone-ve/volto-light-theme that referenced this pull request Sep 7, 2026
…hange) (kitconcept#352)

Co-authored-by: Victor Fernandez de Alba <sneridagh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove border and reduce spacing between title and description in teaser block.

2 participants