Repository navigation
Fix Fat menu A11y issues - #338
Conversation
| desktopMenuOpen === index || | ||
| (!desktopMenuOpen && pathname === item.url), | ||
| })} | ||
| aria-label={intl.formatMessage(messages.openFatMenu)} |
There was a problem hiding this comment.
@iRohitSingh your colleagues from Kitconcept will provide the review for your work on this repo.
What I can suggest is to always look at previous code written and think of reusing the same pattern when possible.
Don't hurry to ask for a review before you test things and think of what info is exposed to the user.
Ex here:
You don't want the screenshot user to read "Open fat menu", "fat" is an implementation detail that should not be exposed to a screenshot user.
You simply need to use the pattern from Mobile navigation
There was a problem hiding this comment.
I thought about the same thing. i.e Open menu but since it contains the navigation of all its content I put fat in middle. We should tell user like it is not a simple menu. Ok, I will change it more appropriate name.
There was a problem hiding this comment.
For current I am changing to only open menu.
* main: Update to Volto 17.12.0 (#342) Release 3.0.0-alpha.3 Fix Fat menu A11y issues (#338) Remove extra site-map from header (#340) Add new commands to run the image in live mode (#332) Upgradetolatest plone and Volto (#331) Allow customization the secondary navigation entries via Portal action (#320) Fix Introduction-Block inline-styles have wrong typography. (#315) Upgrade to Volto 17.11.1 and Plone 6.0.9 (#328)
3 participants
Fix #264