Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync match.go with upstream changes #8

Merged
merged 1 commit into from Jul 9, 2016
Merged

Sync match.go with upstream changes #8

merged 1 commit into from Jul 9, 2016

Conversation

FiloSottile
Copy link
Contributor

Main changes: support for "cmd", fix for golang.org/issue/11407

Main changes: support for "cmd", fix for golang.org/issue/11407
@dmitshur
Copy link
Contributor

dmitshur commented Jul 9, 2016

@kisielk, can you review and merge this PR? It'd be good to keep it up to date with the upstream. And this has some improvements/bug fixes from upstream.

Thanks @FiloSottile for making it!

@kisielk, if you'd like help maintaining this library, I'm happy to volunteer to do that, just give me push rights. :)

@kisielk kisielk merged commit 247e545 into kisielk:master Jul 9, 2016
@kisielk
Copy link
Owner

kisielk commented Jul 9, 2016

Sorry, my GitHub notifications don't seem to work properly unless someone @ mentions me. Not sure why.

@kisielk
Copy link
Owner

kisielk commented Jul 9, 2016

Ah I see now, you can either get email notifications for all activity in repos you're watching, or else just when you're @ mentioned. I'm not sure why there's no option to receive notifications just for repos where you are a contributor, I have a lot of watched repos that I don't work on and don't want to be getting emails for those...

@dmitshur
Copy link
Contributor

dmitshur commented Jul 9, 2016

No problem, thanks for looking at this!

I have a lot of watched repos that I don't work on and don't want to be getting emails for those...

Why do you watch them then? Could you unwatch them?

I usually watch only those repos where I want to be notified of any updates. The ones where I'm explicitly participating show up in the "participating" tabs.

@dmitshur
Copy link
Contributor

dmitshur commented Jul 9, 2016

Hmm, how much review did you do?

The package has build errors now:

gotool $ go build
# github.com/kisielk/gotool
./match.go:158: undefined: allPackages
./match.go:266: undefined: c in c.BuildContext
./match.go:268: undefined: log in log.Print

I didn't review it because I thought it's easier for the person doing the merging.

Do you want help fixing that, or can you take care of it @kisielk?

@dmitshur
Copy link
Contributor

dmitshur commented Jul 9, 2016

I'm working on a fix.

@dmitshur dmitshur mentioned this pull request Jul 9, 2016
@dmitshur
Copy link
Contributor

dmitshur commented Jul 9, 2016

@kisielk, please see #11.

dominikh pushed a commit that referenced this pull request Jul 10, 2016
Followup #8.

Fixes #12.

Closes: gh-11 [via git-merge-pr]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants