Use build tags while loading the import package list too #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, but this is only used for finding imports, not for enumerating their files. Is the problem that some packages have no go files without build tags? |
zimmski
force-pushed
the
use-build-tags-for-the-import-list-too
branch
from
aec102a
to
f734bf3
Compare
|
Yes, that is exactly the problem I want to solve. I should have been more clear on that, sorry. |
kisielk
added a commit
that referenced
this pull request
Aug 15, 2015
…t-too Use build tags while loading the import package list too
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to kisielk/gotool#6
errcheck support build tages but this does not apply to the "..." pattern if the build tags are not forwarded to the loading of the import list.