Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies to work with Go 1.22 #240

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Update dependencies to work with Go 1.22 #240

merged 2 commits into from
Feb 8, 2024

Conversation

addie
Copy link
Contributor

@addie addie commented Feb 7, 2024

This application will crash on Go 1.22 with golang.org/x/tools v0.9.1. This PR upgrades the dependency to v0.17.0.

kisielk
kisielk requested changes Feb 7, 2024
View reviewed changes
Copy link
Owner

@kisielk kisielk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add 1.22 to the build matrix in github actions?

@addie addie requested a review from kisielk February 8, 2024 00:49
@kisielk kisielk mentioned this pull request Feb 8, 2024
Closed
@kisielk kisielk merged commit 338069c into kisielk:master Feb 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisielk kisielk kisielk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addie @kisielk