fix(eslint-plugin): [no-use-before-define] fix false positive type re…

…ference in as, satisfies (typescript-eslint#8474) * fix(eslint-plugin): [no-use-before-define] fix false positive type reference in as, satisfies * chore: add testcase * refactor: condition
kirkwaiblinger · Feb 23, 2024 · 60c1cd3 · 60c1cd3
1 parent 1458920
commit 60c1cd3
Show file tree

Hide file tree

Showing 2 changed files with 66 additions and 1 deletion.
diff --git a/packages/eslint-plugin/src/rules/no-use-before-define.ts b/packages/eslint-plugin/src/rules/no-use-before-define.ts
@@ -317,7 +317,7 @@ export default createRule<Options, MessageIds>({
     ): boolean {
       return (
         variable.identifiers[0].range[1] <= reference.identifier.range[1] &&
-        !isInInitializer(variable, reference)
+        !(reference.isValueReference && isInInitializer(variable, reference))
       );
     }
 

diff --git a/packages/eslint-plugin/tests/rules/no-use-before-define.test.ts b/packages/eslint-plugin/tests/rules/no-use-before-define.test.ts
@@ -529,6 +529,52 @@ class A {
   }
 }
     `,
+    {
+      code: `
+const obj = {
+  foo: 'foo-value',
+  bar: 'bar-value',
+} satisfies {
+  [key in 'foo' | 'bar']: \`\${key}-value\`;
+};
+      `,
+      options: [{ ignoreTypeReferences: false }],
+    },
+    {
+      code: `
+const obj = {
+  foo: 'foo-value',
+  bar: 'bar-value',
+} as {
+  [key in 'foo' | 'bar']: \`\${key}-value\`;
+};
+      `,
+      options: [{ ignoreTypeReferences: false }],
+    },
+    {
+      code: `
+const obj = {
+  foo: {
+    foo: 'foo',
+  } as {
+    [key in 'foo' | 'bar']: key;
+  },
+};
+      `,
+      options: [{ ignoreTypeReferences: false }],
+    },
+    {
+      code: `
+const foo = {
+  bar: 'bar',
+} satisfies {
+  bar: typeof baz;
+};
+
+const baz = '';
+      `,
+      options: [{ ignoreTypeReferences: true }],
+    },
   ],
   invalid: [
     {
@@ -1104,6 +1150,25 @@ const Foo = {
         },
       ],
     },
+    {
+      code: `
+const foo = {
+  bar: 'bar',
+} satisfies {
+  bar: typeof baz;
+};
+
+const baz = '';
+      `,
+      options: [{ ignoreTypeReferences: false }],
+      errors: [
+        {
+          messageId: 'noUseBeforeDefine',
+          data: { name: 'baz' },
+          type: AST_NODE_TYPES.Identifier,
+        },
+      ],
+    },
 
     // "variables" option
     {