fix: synchronize bottom padding with keyboard frame in KeyboardAwareScrollView
#332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Synchronized bottom padding with keyboard frame in
KeyboardAwareScrollView
.💡 Motivation and Context
Original regression was introduced in #257 (these code lines). I decided not animated bottom padding to potentially fix the issue described in #255 (comment)
However such approach is causing unsynchronized animations in certain conditions and I'm not sure, that it actually fixes the problem described in comment above.
So in this PR I'm reworking it again and bringing back animated transitions 👀
Closes #329
📢 Changelog
JS
currentKeyboardFrameHeight
variable;currentKeyboardFrameHeight
variable inonMove
handler;currentKeyboardFrameHeight
for bottom padding in KASV.🤔 How Has This Been Tested?
Tested manually on iPhone 15 Pro + e2e tests.
📸 Screenshots (if appropriate):
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-01-12.at.22.57.58.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-01-13.at.11.15.01.mp4
📝 Checklist