Skip to content

Conversation

@Ale3e
Copy link

@Ale3e Ale3e commented Mar 6, 2025

No description provided.

@Ale3e Ale3e requested review from rascasoft and rndg March 6, 2025 16:32
Copy link
Collaborator

@rascasoft rascasoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some comments, the main directory should be Academy and not AI, but it's something we can modify later on on the review.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This .gitignore is quite nightmarish... hard to maintain and prone to errors: it should be developer responsibility to exclude files that are not part of the repo, instead of having any kind of exclusion here...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the standard suggested by GH. It covers every possible dependency that should not be pushed. Check Here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still find it error prone and very very far from being long term maintainable, mostly because this one is not a Python only repository, but mainly a markdown one.
In any case, no big deal, it can stay as it is, but a so complex template needs to be maintained and kept up-to-date.

@rndg rndg removed their request for review March 12, 2025 12:34
Copy link
Collaborator

@rascasoft rascasoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the result of my tests.

"\n",
" print(f\"Experiment finished. Registered accuracy: {accuracy:.2f}\")"
]
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While trying to reproduce this on a standard Debian 12, within a Python Virtual Environment with all the requirements installed, I'm getting this:

Traceback (most recent call last):
  File "/home/rasca/Labs/venvs/aisetup/mlflow.py", line 3, in <module>
    import mlflow
  File "/home/rasca/Labs/venvs/aisetup/mlflow.py", line 4, in <module>
    import mlflow.sklearn
ModuleNotFoundError: No module named 'mlflow.sklearn'; 'mlflow' is not a package

Maybe it depends on the specific package versions used while writing the lab, so having a requirements.txt would help, but maybe it depends on something else.

Since Python venv should prevent these kind of errors, something needs to be changed/integrated here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rndg just to confirm that I've tried again from scratch, using exactly the steps mentioned in the doc and the result is still the mentioned error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants