Make private albums possible #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbucsy
force-pushed
the
feat/private-albums
branch
from
62b1d5a
to
8863104
Compare
bbucsy
force-pushed
the
feat/private-albums
branch
from
adb5a9c
to
be24991
Compare
bbucsy
force-pushed
the
feat/private-albums
branch
from
69303cf
to
99330f2
Compare
triszt4n
approved these changes
Jan 12, 2022
|
Also @SepsiLaszlo gave me an idea, where we could authorize image resources and shorten the url at the smae time. When the közösségi-pontozás is over, I will look into that. But because its an extension and not a modifications we could use this for the time being. |
SepsiLaszlo
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a way to make albums private by injecting an authorization action in the controllers.
This is done with heavy use of 🧙♂️ Ruby magic 🧞, but to make it a bit civilized i created a folder
app/extensionsto segregate this type of code from the rest of the application.Also in the case an update brokes something you can disable the extensions by setting the OMIT_EXTENSIONS env variable.
closes #54