Skip to content

Improve #491 fix: aria-label when notice title is hidden #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jako wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve #491 fix: aria-label when notice title is hidden #563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/components/consent-notice.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,12 +223,14 @@ export default class ConsentNotice extends React.Component {
manager={manager}
/>
);

const visibleHeader = t(['!', 'consentNotice', 'title']);
const notice = (
<div
role="dialog"
aria-describedby="id-cookie-notice"
aria-labelledby="id-cookie-title"
aria-labelledby={
visibleHeader && config.showNoticeTitle ? 'id-cookie-title' : 'id-cookie-notice'
}
id="klaro-cookie-notice"
tabIndex="0"
autofocus={config.autoFocus}
Expand All @@ -242,7 +244,7 @@ export default class ConsentNotice extends React.Component {
}`}
>
<div className="cn-body">
{t(['!', 'consentNotice', 'title']) && config.showNoticeTitle && (
{visibleHeader && config.showNoticeTitle && (
<h2 id="id-cookie-title">
{t(['consentNotice', 'title'])}
</h2>
Expand Down