Custom Botball objects #556
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug that prevented users from adding custom Botball objects to scenes. In the course of testing, I also discovered another bug which prevented users from adding anything to a scene that isn't a JBC object, which is now fixed.
I also noticed that I had been applying a 100x scaling factor to Botball objects when adding them to the game table scene, without which the objects are so small as to be nearly invisible. To make it easier for users adding them to custom scenes, I applied the correct scaling factor to the GLB files and removed the scaling factor from the table scene.