Update Prometheus Operator #757
Conversation
surajssd
force-pushed
the
surajssd/update-prometheus-operator-new
branch
from
1458bbd
to
fce491f
Compare
surajssd
force-pushed
the
surajssd/update-prometheus-operator-new
branch
4 times, most recently
from
cd349af
to
2aeac56
Compare
surajssd
force-pushed
the
surajssd/update-prometheus-operator-new
branch
3 times, most recently
from
a096768
to
0372f74
Compare
|
@surajssd ping me when this is ready for reviewing :) |
|
@invidian the PR is ready for review, I just saw weird behaviour on AKS that's it. Otherwise the PR is okay to review. |
assets/components/prometheus-operator/manifests/crds/crd-alertmanager.yaml
Show resolved
Hide resolved
|
@invidian I verified the Grafana dashboards. Only there is one problem that |
surajssd
force-pushed
the
surajssd/update-prometheus-operator-new
branch
from
0372f74
to
8dbfe80
Compare
Hm, no, not really. Does it work fine if you install via |
|
@invidian I have verified and it works with helm. |
surajssd
force-pushed
the
surajssd/update-prometheus-operator-new
branch
from
8dbfe80
to
3e2d8ff
Compare
|
I think I have fixed all the issues that were pending. Now this PR is good for final review. |
|
Found the issue, we have two files both called $ find ./ -name apiserver.json
./assets/components/contour/dashboards/apiserver.json$ grep apiserver.json assets/components/prometheus-operator/manifests/
assets/components/prometheus-operator/manifests/templates/grafana/dashboards-1.14/apiserver.yaml
22: apiserver.json: |-I have made changes to the contour dashboard in the last commit. |
.../components/prometheus-operator/manifests/templates/grafana/dashboards-1.14/k8s-coredns.yaml
Show resolved
Hide resolved
assets/components/prometheus-operator/manifests/charts/kube-state-metrics/templates/pdb.yaml
Show resolved
Hide resolved
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
This is change deviating from upstream so that we can get around the issue of long PVC names. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Return when the test that wants error, errors out. This means the test has passed and should not be proceeded further. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
CRDs that don't have annotation `helm.sh/hook: crd-install` cause the helm to install them multiple times thus failing. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Remove the old outdated queries and update it with new metrics. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
This file is renamed so that it does not conflict with the kubernetes apiserver dashboard. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/update-prometheus-operator-new
branch
from
3e2d8ff
to
4b9f218
Compare
No description provided.