-
Notifications
You must be signed in to change notification settings - Fork 49
Conversation
8c1b685
to
ccb2014
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add some docs for this option as well.
Do you mean like a different section in which explains what it does or how to use the toolbox? If it is latter then I intend to cover it in #494 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit but LGTM.
ccb2014
to
4dd28b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM minus the nit. Thanks!
6ae3bcb
to
a4cfc46
Compare
Add a variable `enable_toolbox` to install Rook Ceph toolbox pod to manage and configure Ceph. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
a4cfc46
to
2dfafef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Add a variable
enable_toolbox
to install Rook Ceph toolbox pod tomanage and configure Ceph.
Fixes #594