Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

rook-ceph: Add toolbox configs #649

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Conversation

surajssd
Copy link
Member

Add a variable enable_toolbox to install Rook Ceph toolbox pod to
manage and configure Ceph.

Fixes #594

Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add some docs for this option as well.

@surajssd
Copy link
Member Author

I think we should add some docs for this option as well.

Do you mean like a different section in which explains what it does or how to use the toolbox? If it is latter then I intend to cover it in #494

invidian
invidian previously approved these changes Jun 23, 2020
@surajssd surajssd requested a review from iaguis June 24, 2020 08:14
@surajssd
Copy link
Member Author

PTAL @johananl @iaguis

iaguis
iaguis previously approved these changes Jun 25, 2020
Copy link
Contributor

@iaguis iaguis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit but LGTM.

docs/configuration-reference/components/rook-ceph.md Outdated Show resolved Hide resolved
@surajssd surajssd dismissed stale reviews from iaguis and invidian via 4dd28b6 June 25, 2020 09:49
invidian
invidian previously approved these changes Jun 25, 2020
iaguis
iaguis previously approved these changes Jun 25, 2020
Copy link
Member

@johananl johananl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus the nit. Thanks!

docs/configuration-reference/components/rook-ceph.md Outdated Show resolved Hide resolved
@surajssd surajssd dismissed stale reviews from iaguis and invidian via 3835d56 June 25, 2020 13:53
@surajssd surajssd force-pushed the surajssd/add-rook-toolbox branch 4 times, most recently from 6ae3bcb to a4cfc46 Compare June 29, 2020 05:52
Add a variable `enable_toolbox` to install Rook Ceph toolbox pod to
manage and configure Ceph.

Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Copy link
Contributor

@iaguis iaguis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@surajssd surajssd merged commit 8e9c994 into master Jun 30, 2020
@surajssd surajssd deleted the surajssd/add-rook-toolbox branch June 30, 2020 09:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploying toolbox pod for rook ceph
4 participants