This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Velero: restic plugin add tolerations #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knrt10
force-pushed
the
knrt10/add-tolerations-restic-ds
branch
from
af09f35
to
8b6bbd6
Compare
surajssd
suggested changes
Jan 28, 2021
knrt10
force-pushed
the
knrt10/add-tolerations-restic-ds
branch
from
8b6bbd6
to
5758a32
Compare
|
@surajssd added |
knrt10
force-pushed
the
knrt10/add-tolerations-restic-ds
branch
from
5758a32
to
3e46bb2
Compare
I don't see tests being added. |
|
Just to confirm, by config conversion doesn't it mean to add tolerations to restic config tests and check whether it is right or not? |
I think what @surajssd meant was to add tests, that toleration actually appears in the right place in the rendered manifests. |
knrt10
force-pushed
the
knrt10/add-tolerations-restic-ds
branch
from
3e46bb2
to
8dc9cc0
Compare
|
@surajssd added the tests. Please check |
invidian
suggested changes
Jan 29, 2021
knrt10
force-pushed
the
knrt10/add-tolerations-restic-ds
branch
from
8dc9cc0
to
cd3982c
Compare
invidian
previously approved these changes
Jan 29, 2021
This commit adds a new attribute `tolerations` which will add tolerations to restic DaemonSet. Since the cluster has multiple node pools with different purposes, it adds an ability to deploy the restic DaemonSet on the nodes that need to backup the PVC. Add test that tolerations are set correctly. closes: #1334 Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10
force-pushed
the
knrt10/add-tolerations-restic-ds
branch
from
cd3982c
to
88dcb36
Compare
invidian
approved these changes
Jan 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new attribute
tolerationswhich will add tolerations to restic DaemonSet.Since the cluster has multiple node pools with different purposes, it
adds an ability to deploy the restic DaemonSet on the nodes that need to
backup the PVC.
closes: #1334
Signed-off-by: knrt10 kautilya@kinvolk.io